Skip to content

$40 | New Nav: Business related options should be enabled only for copilots and topcoder employees #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nithyaasworld opened this issue Jun 18, 2019 · 8 comments
Closed

$40 | New Nav: Business related options should be enabled only for copilots and topcoder employees #2639

nithyaasworld opened this issue Jun 18, 2019 · 8 comments
Assignees
@gets0ul @luizrrodrigues
Labels
nav_Assigned nav_FixAccepted nav_Paid Navigation P1 Urgent (resolve within 24 hours)

Comments

@nithyaasworld
Copy link
Collaborator

nithyaasworld commented Jun 18, 2019 •
edited by Oanh-and-only-Oanh
Loading

"Switch to Business" option in drop down User menu - This should be visible only to copilots and topcoder employees. Disable for all other users.
image
@nithyaasworld nithyaasworld added the P1 Urgent (resolve within 24 hours) label Jun 18, 2019
@gets0ul
Copy link
Collaborator

gets0ul commented Jun 18, 2019

Can I work on this?

@luizrrodrigues
Copy link
Collaborator

@gets0ul Yes, we need close this ASAP.
Let me know if you have any questions.

@gets0ul
Copy link
Collaborator

gets0ul commented Jun 18, 2019 •
edited
Loading

@luizrrodrigues
Where to look for data to check if a user is an employee?
Is there any backend API providing this?
What employee account to use for test? Do you have any?

Should we look on user's role(s) when checking whether user is employee?
What role that make one an employee?

@luizrrodrigues luizrrodrigues changed the title New Nav: Business related options should be enabled only for copilots and topcoder employees $40 | New Nav: Business related options should be enabled only for copilots and topcoder employees Jun 18, 2019
@luizrrodrigues
Copy link
Collaborator

@gets0ul Sorry delay here.

If API end point don't return Employee or Copilot status, just hide for now.

This was referenced Jun 19, 2019
Merged
Merged
@gets0ul
Copy link
Collaborator

gets0ul commented Jun 19, 2019

PR: #2643
navigation-component: topcoder-platform/navigation-component#24

@luizrrodrigues
Copy link
Collaborator

@gets0ul Need fix circleci errors

@luizrrodrigues
Copy link
Collaborator

@gets0ul Fixed accepted, good job.

Please fix CircleCI errors.

Thanks.

@gets0ul
Copy link
Collaborator

gets0ul commented Jun 19, 2019

@luizrrodrigues Done, fixed.
Thanks.

luizrrodrigues added a commit that referenced this issue Jun 19, 2019
@luizrrodrigues
Merge pull request #2643 from gets0ul/issue-2639
a157b32 
Fix Issue #2639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gets0ul gets0ul

@luizrrodrigues luizrrodrigues

Labels
nav_Assigned nav_FixAccepted nav_Paid Navigation P1 Urgent (resolve within 24 hours)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gets0ul @nithyaasworld @luizrrodrigues