Skip to content

Server-side rendering of the leaderboard #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
birdofpreyru opened this issue May 11, 2017 · 0 comments
Closed

Server-side rendering of the leaderboard #25

birdofpreyru opened this issue May 11, 2017 · 0 comments

Comments

@birdofpreyru
Copy link
Collaborator

It looks from the code that winner has supported server-side rendering of the page, but it does not work correctly, according to the warning in the browser console:

bundle.js:26959 Warning: React attempted to reuse markup in a container but the checksum was invalid. This generally means that you are using server rendering and the markup generated on the server was not what the client was expecting. React injected new markup to compensate which works but you have lost many of the benefits of server rendering. Instead, figure out why the markup being generated is different on the client or server:
 (client) .w3.org/1999/xlink" class="src-shared-co
 (server) .w3.org/1999/xlink" data-reactid="27"><t

Probably it is related to how the mocked data are handled, and will be automatically resolved, once we move to real API for fetching leaderboard data.

birdofpreyru added a commit that referenced this issue May 15, 2017
sushilshinde pushed a commit that referenced this issue Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant