Skip to content

[$60] - Menu stays forever when user move the mouse down over COMPETE/LEARN/COMMUNITY #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdgun opened this issue Aug 24, 2017 · 6 comments
Assignees

Comments

@sdgun
Copy link
Collaborator

sdgun commented Aug 24, 2017

Steps to Reproduce

Actual Result(s)

  • Menu stays forever when user move the mouse down over COMPETE/LEARN/COMMUNITY

Expected Result(s)

  • Must close the menu when user tap on a empty space

Environment

  • Device(s): Laptop
  • Operating System: Windows 7 64bit
  • Browser(s): Chrome 60.0.3112.101 (Official Build) (64-bit)

Image/Video/JS Log/Console Log (If not attached here, Please check the comments section)

@sdgun
Copy link
Collaborator Author

sdgun commented Aug 24, 2017

2017-08-25_5-05-05

@birdofpreyru
Copy link
Collaborator

@sdgun Not sure about this one. When I click on empty space, then move mouse out of the menu, it still collapses. Do you mean, that we should close the menu immediately if we click on its empty part (dark gray zone)? It does not look that obvious to me. @vic-topcoder ?

@vic-tian
Copy link

That's a mobile interaction you're describing: on mobile to invoke the menu one has to tap to simulate hover state. On desktop it should not happen. I cannot reproduce this on my side. If your mouse is outside the menu, it should collapse. Always-persistent menu is a bug

@sdgun
Copy link
Collaborator Author

sdgun commented Aug 25, 2017

@vic-topcoder @birdofpreyru Please give me sometime I will comment the exact steps. I can reproduce this 8/10 times

@sdgun
Copy link
Collaborator Author

sdgun commented Aug 25, 2017

@birdofpreyru Please check the attached video;

https://www.screencast.com/t/lzsEbOULW

@birdofpreyru
Copy link
Collaborator

@sdgun Ahhh... I see. It looks the actual reason is that you scroll at the same time when the menu is being opened, so this interfere with JS code taking care about the menu. Accepted, 5 points.

Expected Fix

The logic behind sub-menu expansion / collapsing should be revised to ensure that scrolling does not break it.

@birdofpreyru birdofpreyru changed the title Menu stays forever when user move the mouse down over COMPETE/LEARN/COMMUNITY [$60] - Menu stays forever when user move the mouse down over COMPETE/LEARN/COMMUNITY Aug 25, 2017
@ordinaryname ordinaryname self-assigned this Aug 25, 2017
@ordinaryname ordinaryname removed their assignment Aug 27, 2017
@Colinh84 Colinh84 self-assigned this Aug 27, 2017
@Colinh84 Colinh84 removed their assignment Aug 28, 2017
@elfman elfman self-assigned this Aug 28, 2017
elfman added a commit to elfman/community-app that referenced this issue Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants