Skip to content

[$130] - 'TCO18' Tag in subheading of challenge details not consistent with design spec. #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Aug 24, 2017 · 3 comments
Assignees

Comments

@ghost
Copy link

ghost commented Aug 24, 2017

Steps to Reproduce

  1. Login to open http://community-app.topcoder.com/challenges/30058868/?type=design#winner
  2. Observe 'TCO18' tag under heading title of the challenge
  3. Also open http://community-app.topcoder.com/challenges/30058970/?type=develop
  4. Observe 'TCO18' Tag at same location for this development challenge.
  5. Also check 'Header' styleguide in design spec.

Screenshots :
image
image

Expected Result: As per design spec, the mentioned 'TCO' tag should be stylised in such a way that its background to be in light shade of color specific to the challenge type and letters to be written in true color.Hence, here 'TCO18' tag for design challenge should show light blue background with wording written in blue.

Current Result: In current system, for design challenges 'TCO18' tag is present in incorrect format.However, for development challenge it is coorect and consistent with design spec.

Browser : Chrome Version 59.0.3071.115 (Official Build) (64-bit)
OS : Windows 8.1

@birdofpreyru birdofpreyru changed the title 'TCO18' Tag in subheading of challenge details not consistent with design spec. [$80] - 'TCO18' Tag in subheading of challenge details not consistent with design spec. Aug 24, 2017
@birdofpreyru
Copy link
Collaborator

Accepted, 1 point

Expected Fix

I would like to make the fix in a fancy way: check the new implementation for buttons, themed using react-css-themr in /src/shared/components/buttons. These tags are, basically, button-like links with different styling, so we should just add additional themes to style that standard button component as tags, and ensure that proper theme is taken from ThemeProvider.

Feel free to ask for more details, if the brief note above does not look creal to you.

@Colinh84
Copy link
Contributor

@shubhendusaurabh Did you tag the wrong issue here, or did you really submit a fix for the issue I am assigned?

@shubhendusaurabh
Copy link
Contributor

@Colinh84 sorry my bad. I meant #211

@Colinh84 Colinh84 mentioned this issue Aug 25, 2017
birdofpreyru added a commit that referenced this issue Aug 27, 2017
fixed #221 added $ for reliability bonus
@birdofpreyru birdofpreyru changed the title [$80] - 'TCO18' Tag in subheading of challenge details not consistent with design spec. [$130] - 'TCO18' Tag in subheading of challenge details not consistent with design spec. Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants