Skip to content

[$30] - [Common] Empty filter can be saved #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sdgun opened this issue Aug 24, 2017 · 3 comments · Fixed by #275
Closed

[$30] - [Common] Empty filter can be saved #216

sdgun opened this issue Aug 24, 2017 · 3 comments · Fixed by #275
Assignees
@shubhendusaurabh

Comments

@sdgun
Copy link
Collaborator

sdgun commented Aug 24, 2017

Steps to Reproduce

Actual Result(s)

  • Empty filter can be saved

Expected Result(s)

  • Must validate before saveing empty filter

Environment

  • Device(s): Laptop
  • Operating System: Windows 7 64bit
  • Browser(s): Chrome 60.0.3112.101 (Official Build) (64-bit)

Image/Video/JS Log/Console Log (If not attached here, Please check the comments section)
@sdgun
Copy link
Collaborator Author

sdgun commented Aug 24, 2017

21

@birdofpreyru
Copy link
Collaborator

Accepted, 3 points

@birdofpreyru birdofpreyru changed the title [Common] Empty filter can be saved [$30] - [Common] Empty filter can be saved Aug 24, 2017
@shubhendusaurabh
Copy link
Contributor

assigning myself

shubhendusaurabh added a commit to shubhendusaurabh/community-app that referenced this issue Aug 25, 2017
@shubhendusaurabh
fixed topcoder-platform#216 disabled save button for empty filters
fc77465
@shubhendusaurabh shubhendusaurabh mentioned this issue Aug 25, 2017
Merged
@birdofpreyru birdofpreyru mentioned this issue Aug 28, 2017
Closed
birdofpreyru added a commit that referenced this issue Aug 29, 2017
@birdofpreyru
Merge pull request #275 from shubhendusaurabh/issue-216
53c8013 
fixed #216 disabled save button for empty filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubhendusaurabh shubhendusaurabh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed #216 disabled save button for empty filters shubhendusaurabh/community-app
3 participants
@shubhendusaurabh @sdgun @birdofpreyru