Skip to content

[$200] Settings > Tools: "Your Information has been updated' shown when switching the tabs after deleting a Devices/Software/Service Providers/Subscriptions #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codejamtc opened this issue Mar 16, 2019 · 13 comments

Comments

@codejamtc
Copy link
Collaborator

  1. Open the application and login as TonyJ
  2. Hover over the profile avatar > Click Settings
  3. Click Tools Tab > Devices/Software/Service Providers/Subscriptions
  4. Delete an item
  5. Go to the Profile tab; "Your Information has been updated' shown

Actual: "Your Information has been updated' shown when switching the tabs after deleting a Devices/Software/Service Providers/Subscriptions

Expected: Should not show messages on the profile page

Reproducibility Rate: 3/3

Environment: Google Pixel XL, Android 9.0 | Browser: Google Chrome 73.0.3683.75

@ThomasKranitsas
Copy link
Contributor

The notifications don't seem to work properly

@ThomasKranitsas ThomasKranitsas changed the title Settings > Tools: "Your Information has been updated' shown when switching the tabs after deleting a Devices/Software/Service Providers/Subscriptions [$80] Settings > Tools: "Your Information has been updated' shown when switching the tabs after deleting a Devices/Software/Service Providers/Subscriptions Apr 8, 2019
@ThomasKranitsas
Copy link
Contributor

@topcoder-platform/topcodercompetitors this is open for pickup and needs to be checked and fixed in all subpages in the settings page

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30088204 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30088204 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30088204 has been updated - it has been assigned to applehit16.

This is an automated message for thomaskranitsas via Topcoder X

@Gauravseta
Copy link
Collaborator

@ThomasKranitsas any more open for pickup soon?

@ThomasKranitsas
Copy link
Contributor

Yes, I'll open more tomorrow. Stay tuned!

@ThomasKranitsas
Copy link
Contributor

ThomasKranitsas commented Apr 9, 2019

@applehit16 ignore the delete button for now.

The notifications seem to have many issues. Can you please fix them across the settings page?
The notifications should be properly shown when the data gets updated and should be dismissed when you change tab/page.

Let me know if the effort is too much for this.
I may have to run a challenge for this if it needs a lot of effort.

@applehit16
Copy link
Contributor

@ThomasKranitsas To fix them, I need to first understand what the issue is... I tried to follow the op's instruction, and nothing happens to me. https://drive.google.com/open?id=1_p7XdcDOfgosnK_BAkyP7VeZm8GD2lxC

So to my understanding now, the issue has become that notification doesn't show up when you delete an item. I'll look into this first, and see if It will be dismissed when switching tabs

@ThomasKranitsas
Copy link
Contributor

Correct, the notification should show up when you edit anything in your settings/traits.

Again, let me know if the effort is too much for this ticket

@applehit16
Copy link
Contributor

@ThomasKranitsas looking into it, will keep you updated

@topcoder-platform topcoder-platform deleted a comment from liqiang372 Apr 13, 2019
@ThomasKranitsas ThomasKranitsas changed the title [$80] Settings > Tools: "Your Information has been updated' shown when switching the tabs after deleting a Devices/Software/Service Providers/Subscriptions [$200] Settings > Tools: "Your Information has been updated' shown when switching the tabs after deleting a Devices/Software/Service Providers/Subscriptions Apr 18, 2019
ThomasKranitsas added a commit that referenced this issue Apr 18, 2019
…mprove

#2096 Fix settings notifications not showing when update user traits
@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30088204 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30088204

This is an automated message for thomaskranitsas via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants