[$40] Settings > Account > My Account: Entering incorrect current password to change the password won't show any validation

[codejamtc]

1. Open the application and login as Manager (pshah_manager)
2. Hover over the profile avatar > Click Settings
3. Click Account Tab > My Account
4. Enter 'qwert123@' to the new password field
5. Enter '123456' as Current password
6. Click Change Password

Actual: Entering incorrect current password to change the password won't show any validation

Expected: Should show a validation because the current password entered into the field is incorrect

Reproducibility Rate: 3/3

Environment: HP Pavilion x360 14 inch; Windows 10 | Browser: Google Chrome 73.0.3683.75

[ThomasKranitsas]

Contest https://www.topcoder.com/challenges/30086772 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

[ThomasKranitsas]

Contest https://www.topcoder.com/challenges/30086772 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

[RAJKUMARRRR]

i want to work on this issue, can you change the label

[ThomasKranitsas]

@RAJKUMARRRR please use this link https://x.topcoder.com/api/v1/github/teams/registration/7946e40e-f01a-4ced-a1c2-081e328c7d73-1553097709824 to access our org so you can assign yourself

[ThomasKranitsas]

Contest https://www.topcoder.com/challenges/30086772 has been updated - it has been assigned to LieutenantRoger.

This is an automated message for thomaskranitsas via Topcoder X

[LieutenantRoger]

Hey @ThomasKranitsas ,

So when the password is incorrect, how do we notify the user ?

[ThomasKranitsas]

Hey @LieutenantRoger ,

Please show an error like the one from the following screenshot:

[ThomasKranitsas]

The error can say The old password is invalid

[LieutenantRoger]

https://take.ms/skp6M

Can we show a tip like this ? To match the popup with the email invalid state on this same screen ?

[ThomasKranitsas]

No, please use the one I shared above

[LieutenantRoger]

Ok, https://take.ms/XL8WY does this style look good to you ? I picked an existing one.

And this is only for client side validation, we won't check with backend about whether current password correct or wrong, right ? Because invalid only indicates a format error.

[ThomasKranitsas]

I think there's a misunderstanding here... This error is shown when you submit the form and the backend returns an error.

It's not a form validation error, it's a bad request error

[LieutenantRoger]

Hey @ThomasKranitsas, I have read the backend codebase, it looks like the topcoder-react-lib didn't handle the error case when updating failed.

Can we use fireErrorMessage('The old password is invalid'); to notify user about the fail ? As I can see there are other errors in the topcoder-react-lib is using this way to alert error.

The way you showed above actually was a client validation style.

Let me know your thoughts.

[ThomasKranitsas]

That sounds good

…

On Thu, 21 Mar 2019 at 14:58, LieutenantRoger ***@***.***> wrote: Hey @ThomasKranitsas <https://github.com/ThomasKranitsas>, I have read the backend codebase, it looks like the topcoder-react-lib didn't handle the error case when updating failed. Can we use fireErrorMessage('The old password is invalid'); to notify user about the fail ? As I can see there are other errors in the topcoder-react-lib is using this way to alert error. The way you showed above actually was a client validation style. Let me know your thoughts. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2056 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEZjOQv6hVXWo8a_Kq328XfkWuRQYgdgks5vY4H9gaJpZM4b3Vu-> .

[LieutenantRoger]

ok, do I create a pull request on topcoder-react-lib master branch? I didn't find a bug-bash branch on that codebase.

[ThomasKranitsas]

Please use the develop branch

…

On Thu, 21 Mar 2019 at 15:07, LieutenantRoger ***@***.***> wrote: ok, do I create a pull request on topcoder-react-lib master branch? I didn't find a bug-bash branch on that codebase. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2056 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEZjOcN-lA_kKbIQBq4CYOTST77zkJgNks5vY4QZgaJpZM4b3Vu-> .

[LieutenantRoger]

When I modify the topcoder-react-lib in the community codebase's node_module folder, and re-build the community-app, do you know why the bundled topcoder-react-lib is not containing my update to the topcoder-react-lib ?

[ThomasKranitsas]

You also need to build the topcoder-react-lib before you replace it in the community-app

[LieutenantRoger]

factory:45ms building:314ms = 359ms

ERROR in ./src/index.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
ReferenceError: [BABEL] /Users/Roger/w/bb/tc/topcoder-react-lib/src/index.js: Unknown option: base.envName. Check out http://babeljs.io/docs/usage/options/ for more information about options.

A common cause of this error is the presence of a configuration options object without the corresponding preset name. Example:

Invalid:
  `{ presets: [{option: value}] }`
Valid:
  `{ presets: [['presetName', {option: value}]] }`

For more detailed information on preset configuration, please see https://babeljs.io/docs/en/plugins#pluginpresets-options.
    at Logger.error (/Users/Roger/w/bb/tc/topcoder-react-lib/node_modules/babel-core/lib/transformation/file/logger.js:41:11)
    at OptionManager.mergeOptions (/Users/Roger/w/bb/tc/topcoder-react-lib/node_modules/babel-core/lib/transformation/file/options/option-manager.js:226:20)
    at OptionManager.init (/Users/Roger/w/bb/tc/topcoder-react-lib/node_modules/babel-core/lib/transformation/file/options/option-manager.js:368:12)
    at File.initOptions (/Users/Roger/w/bb/tc/topcoder-react-lib/node_modules/babel-core/lib/transformation/file/index.js:212:65)
    at new File (/Users/Roger/w/bb/tc/topcoder-react-lib/node_modules/babel-core/lib/transformation/file/index.js:135:24)
    at Pipeline.transform (/Users/Roger/w/bb/tc/topcoder-react-lib/node_modules/babel-core/lib/transformation/pipeline.js:46:16)
    at transpile (/Users/Roger/w/bb/tc/topcoder-react-lib/node_modules/babel-loader/lib/index.js:50:20)
    at Object.module.exports (/Users/Roger/w/bb/tc/topcoder-react-lib/node_modules/babel-loader/lib/index.js:173:20)
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] build:dev: `webpack --env=development --progress --profile --colors --display-optimization-bailout`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] build:dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/Roger/.npm/_logs/2019-03-21T16_07_08_072Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] build: `npm run clean && npm run build:dev && npm run build:prod`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/Roger/.npm/_logs/2019-03-21T16_07_08_106Z-debug.log

I can't build topcoder-react-lib both develop and master branch, can you see the issue ?

[LieutenantRoger]

@ThomasKranitsas
Please check this PR against topcoder-react-lib
Thanks.
topcoder-platform/topcoder-react-lib#48

[ThomasKranitsas]

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30086772

This is an automated message for thomaskranitsas via Topcoder X