Skip to content

[$30]Dashboard SRMS pick timings from Contest Table, Should pick up from Round Table - Registration Date #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harshitmehta15 opened this issue Jan 10, 2019 · 28 comments

Comments

@harshitmehta15
Copy link

harshitmehta15 commented Jan 10, 2019

Describe the bug
SRMs displayed on dashboard pick date from Contest Table in OLTP. However, they should be picking the date from Round table one single contest can have multiple rounds
To Reproduce
Go to topcoder.com/my-dashboard and look for SRMs.

Looking at the screenshot you can see the SRMs picking contest date, however they should pick the round registration date marked in green :)

screen shot 2019-01-10 at 12 55 30

@harshitmehta15
Copy link
Author

@ajefts Who should I assign this issue to?

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jan 11, 2019

@harshitmehta123 I'm checking with @skyhit on this, probably an API issue.

@skyhit
Copy link
Contributor

skyhit commented Jan 11, 2019

@sushilshinde @harshitmehta123 seems not API, but UI, the response is like

{"id":"-1efdeffd:1683b710828:-1d0","result":{"success":true,"status":200,"metadata":{"fields":null,"totalCount":6},"content":[{"id":17395,"name":"TCO19 SRM 746","type":null,"status":"FUTURE","startDate":"2019-01-09T17:18:00.000Z","endDate":"2019-01-09T17:18:00.000Z","track":"DATA_SCIENCE","subTrack":"SRM","numRegistrants":[0],"userIds":[],"handles":null,"rounds":[{"id":17395,"registrationStartAt":"2019-01-14T22:00:00.000Z","registrationEndAt":"2019-01-15T21:55:00.000Z","codingStartAt":"2019-01-15T22:00:00.000Z","codingEndAt":"2019-01-15T23:15:00.000Z","systemTestStartAt":"2019-01-15T23:35:00.000Z","systemTestEndAt":"2019-01-15T23:35:00.000Z","status":"FUTURE","forumId":null}]},{"id":17396,"name":"TCO19 SRM 747","type":null,"status":"FUTURE","startDate":"2019-01-09T17:20:00.000Z","endDate":"2019-01-09T17:20:00.000Z","track":"DATA_SCIENCE","subTrack":"SRM","numRegistrants":[0],"userIds":[],"handles":null,"rounds":[{"id":17396,"registrationStartAt":"2019-01-18T21:00:00.000Z","registrationEndAt":"2019-01-19T20:55:00.000Z","codingStartAt":"2019-01-19T21:00:00.000Z","codingEndAt":"2019-01-19T22:15:00.000Z","systemTestStartAt":"2019-01-19T22:35:00.000Z","systemTestEndAt":"2019-01-19T22:35:00.000Z","status":"FUTURE","forumId":null}]},{"id":17397,"name":"TCO19 SRM 748","type":null,"status":"FUTURE","startDate":"2019-01-09T17:35:00.000Z","endDate":"2019-01-09T17:35:00.000Z","track":"DATA_SCIENCE","subTrack":"SRM","numRegistrants":[0],"userIds":[],"handles":null,"rounds":[{"id":17397,"registrationStartAt":"2019-01-25T22:00:00.000Z","registrationEndAt":"2019-01-26T21:55:00.000Z","codingStartAt":"2019-01-26T22:00:00.000Z","codingEndAt":"2019-01-26T23:15:00.000Z","systemTestStartAt":"2019-01-26T23:35:00.000Z","systemTestEndAt":"2019-01-26T23:35:00.000Z","status":"FUTURE","forumId":null}]}]},"version":"v3"}```

while,  you can see all three SRMs are starting in the same time?

@harshitmehta15
Copy link
Author

Currently, it is picking Contest: startTime ....but we need to change it to registrationStartAt time in the rounds array

@sushilshinde
Copy link
Collaborator

@harshitmehta123 does registrationStartA has the correct value in this response?

@sushilshinde sushilshinde changed the title Dashboard SRMS pick timings from Contest Table, Should pick up from Round Table - Registration Date [$30]Dashboard SRMS pick timings from Contest Table, Should pick up from Round Table - Registration Date Jan 13, 2019
@sushilshinde
Copy link
Collaborator

@topcoder-platform/topcodercompetitors this one is open for pickup

PR on https://github.com/topcoder-platform/community-app/tree/hot-fixes

@codeMinter codeMinter self-assigned this Jan 13, 2019
@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30079108 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30079108 has been updated - it has been assigned to gurmeetb.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30079108 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@codeMinter
Copy link
Contributor

@sushilshinde looks like this is working fine already. Kindly validate once on your side on PROD.

isfixedalready

@sushilshinde
Copy link
Collaborator

@harshitmehta123 please comment

@codeMinter
Copy link
Contributor

@sushilshinde I am putting this on hold until we hear back from @harshitmehta123

@harshitmehta15
Copy link
Author

harshitmehta15 commented Jan 15, 2019

Hey! @sushilshinde @gurmeetb
You see that for SRM 746 because SRM 746 is scheduled to start on 14th Jan. Check for SRM 747, it should show 19th Jan, but is showing 13th Jan.
In the contest start date we had 4th jan, but if the contest has not started it will show you the current date. So 747 is also showing you the current date.

@sushilshinde
Copy link
Collaborator

@harshitmehta123 can you verify

https://beta-community-app.topcoder.com/my-dashboard

@harshitmehta15
Copy link
Author

Hi! Thanks for fixing!
The time displayed looks a little off. What time zone is it displaying time in? Can you check?
@sushilshinde

@harshitmehta15
Copy link
Author

harshitmehta15 commented Jan 17, 2019

Should it not display the current time zone, like the arena does, or if not - it should have time zone written alongside it :)
Possible Solutions

  1. Showtime in members time zone!
  2. Topcoder Time is preferably EST. If you can change it to UTC-5 time and mention UTC-5 that would also help :)

@sushilshinde
Copy link
Collaborator

Ok

@codeMinter
Copy link
Contributor

codeMinter commented Jan 17, 2019

srms

@harshitmehta123 🤔 ?

codeMinter added a commit that referenced this issue Jan 17, 2019
codeMinter added a commit that referenced this issue Jan 17, 2019
sushilshinde added a commit that referenced this issue Jan 18, 2019
@sushilshinde
Copy link
Collaborator

@harshitmehta123 shall we close this

https://beta-community-app.topcoder.com/my-dashboard

@harshitmehta15
Copy link
Author

Thanks for adding the time zone, however - the time displayed is UTC and the time zone it's showing is UTC+5:30. Registration for SRM 748 begins at 22:30 IST on Jan 25. The time shown in the screenshot above it 3:30am which is UTC time .. but the time zone mentioned below is UTC+5:30.

@codeMinter
Copy link
Contributor

@harshitmehta123 FYI - all looks good here to me👇

srm_snapshot

utc_time_to_ist

@codeMinter
Copy link
Contributor

@sushilshinde @harshitmehta123 any updates here☝️

@harshitmehta15
Copy link
Author

Hi @gurmeetb, I think there is an issue with the timings the API is returning.. These are the SRM timings in various time zones. I am investigating and will as soon as possible.

Round Details:
SRM 748 — January 25, 12:00 UTC-5
SRM 748 — January 25, 17:00 UTC
SRM 748 — January 25, 10:30 UTC + 5:30

SRM 749 — February 1, 7:00 UTC-5
SRM 749 -- February 1, 12:00 UTC
SRM 749 -- February 1, 17:30 UTC+5:30

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jan 22, 2019

Shall we close this issue now Timezone text and other things are fixed by @gurmeetb? @harshitmehta123 you can open an issue on API repo.

@codeMinter
Copy link
Contributor

I agree with @sushilshinde - once API is fixed, this will work fine as it does with current time coming in response.

@harshitmehta123 thoughts 🤔 ?

@sushilshinde
Copy link
Collaborator

@harshitmehta123 please create ticket on https://github.com/appirio-tech/ap-challenge-microservice/

@ThomasKranitsas
Copy link
Contributor

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30079108

This is an automated message for thomaskranitsas via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants