Skip to content

fix: send amount in cents in prize sets when doing challenge:update #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ workflows:
branches:
only:
- dev
- PLAT-3491
- hotfix/budget-update

- "build-qa":
context: org-global
Expand Down
19 changes: 13 additions & 6 deletions src/common/challenge-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -356,9 +356,12 @@ class ChallengeHelper {
}

if (data.prizeSets != null) {
ChallengeHelper.convertPSValuesToCents(data.prizeSets)
console.log('Converted prizeSets to cents', data.prizeSets)
data.prizeSetUpdate = {
prizeSets: data.prizeSets,
prizeSets: [...data.prizeSets],
};
console.log('prizeSetUpdate', data.prizeSetUpdate)
delete data.prizeSets;
}

Expand Down Expand Up @@ -465,11 +468,7 @@ class ChallengeHelper {
}
}

convertToISOString(startDate) {
return ChallengeHelper.convertDateToISOString(startDate);
}

convertPrizeSetValuesToCents(prizeSets) {
static convertPSValuesToCents(prizeSets){
prizeSets.forEach((prizeSet) => {
prizeSet.prizes.forEach((prize) => {
prize.amountInCents = new Decimal(prize.value).mul(100).toNumber();
Expand All @@ -478,6 +477,14 @@ class ChallengeHelper {
});
}

convertToISOString(startDate) {
return ChallengeHelper.convertDateToISOString(startDate);
}

convertPrizeSetValuesToCents(prizeSets) {
return ChallengeHelper.convertPSValuesToCents(prizeSets);
}

convertPrizeSetValuesToDollars(prizeSets, overview) {
prizeSets.forEach((prizeSet) => {
prizeSet.prizes.forEach((prize) => {
Expand Down
3 changes: 0 additions & 3 deletions src/services/ChallengeService.js
Original file line number Diff line number Diff line change
Expand Up @@ -1890,9 +1890,6 @@ async function updateChallenge(currentUser, challengeId, data) {
grpcMetadata.set("userId", currentUser.userId);
grpcMetadata.set("token", await getM2MToken());

if (updateInput.prizeSetUpdate != null) {
convertPrizeSetValuesToCents(updateInput.prizeSetUpdate.prizeSets);
}
await challengeDomain.update(
{
filterCriteria: getScanCriteria({ id: challengeId }),
Expand Down