Skip to content

Task status change #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Task status change #665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/services/ChallengeService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1423,15 +1423,15 @@ function validateTask(currentUser, challenge, data, challengeResources) {
return;
}

// Status from Draft -> Active, indicating launch a Task
// Status changed to Active, indicating launch a Task
const isLaunchTask =
data.status === constants.challengeStatuses.Active &&
challenge.status === constants.challengeStatuses.Draft;
challenge.status !== constants.challengeStatuses.Active;

// Status from Active -> Completed, indicating complete a Task
// Status changed to Completed, indicating complete a Task
const isCompleteTask =
data.status === constants.challengeStatuses.Completed &&
challenge.status === constants.challengeStatuses.Active;
challenge.status !== constants.challengeStatuses.Completed;

// When complete a Task, input data should have winners
if (isCompleteTask && (!data.winners || !data.winners.length)) {
Expand Down