Skip to content

Create Challenge : Validate Group Ids are valid or not #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

sarojbehera1
Copy link
Contributor

No description provided.

Copy link

@liuliquan liuliquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There is an existing helper.getGroupById function, should use that function to get group by id
  2. The validation logic for groups existence are almost same for create/update challenge, should create a new common function to validate.
  3. Use Promise.all() to retrieve groups in parallel, something like https://github.com/topcoder-platform/challenge-api/blob/dev/src/services/ChallengeService.js#L490-L501

@sarojbehera1 sarojbehera1 force-pushed the feature/PLAT-2528 branch 2 times, most recently from bcc660e to 30fc001 Compare October 5, 2023 21:06
@sarojbehera1 sarojbehera1 force-pushed the feature/PLAT-2528 branch 5 times, most recently from 3bbdd6f to e40db81 Compare October 6, 2023 07:03
@eisbilir eisbilir self-requested a review October 9, 2023 11:38
@rakibansary rakibansary merged commit 15ebae8 into topcoder-platform:dev Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants