feat: add phase management api #635

rakibansary · 2023-05-15T13:52:54Z

No description provided.

Signed-off-by: Rakib Ansary <[email protected]>

eisbilir · 2023-05-17T12:31:38Z

src/services/ChallengeService.js

@@ -2235,6 +2209,115 @@ deleteChallenge.schema = {
  challengeId: Joi.id(),
 };

+async function advancePhase(currentUser, challengeId, data) {
+  if (currentUser && (currentUser.isMachine || hasAdminRole(currentUser))) {


this check looks unnecessary

eisbilir · 2023-05-17T12:34:40Z

src/services/ChallengeService.js

+      );
+
+      const updatedChallenge = await challengeDomain.lookup(getLookupCriteria("id", challengeId));
+      await indexChallengeAndPostToKafka(updatedChallenge);


we can avoid raising challenge.update event unless there is a change in challenge status or winners are set.
for other cases, we need to raise event using another topic and another format

eisbilir · 2023-05-18T07:00:14Z

src/phase-management/PhaseAdvancer.js

+  }
+
+  async #areAllSubmissionsReviewed(challengeId) {
+    console.log(`Getting review count for challenge ${challengeId}`);


Note: also we need to check if enough review is present per submission according to "Reviewer Count" phase constraint.

I will double check - however areAllSubmissionReviewed is an essential rule while checking if all submissions received the minimum requisite reviews would be a constraint check

eisbilir · 2023-05-18T07:16:46Z

src/phase-management/phase-rules.json

+            {
+              "fact": "isPredecessorPhaseClosed",
+              "operator": "equal",
+              "value": true


predecessor phase is "Submission" and it can be open
regular "isClosed" check can be added

eisbilir · 2023-05-18T07:21:09Z

src/phase-management/phase-rules.json

+              "value": true
+            },
+            {
+              "fact": "isPostMortemOpen",


this looks unnecessary, post mortem is created following registration and submission. If Appeals response is already scheduled then it means that there is no post mortem created in the system.

eisbilir · 2023-05-18T07:24:24Z

src/phase-management/phase-rules.json

+                  "value": true
+                },
+                {
+                  "all": [


I couldn't understand why submission phase is closed here if this is F2F and there is a submission pending to be reviewed.

Yeah this is an oversight - submission should not be closed! I'll fix it.

eisbilir · 2023-05-18T07:42:21Z

src/phase-management/PhaseAdvancer.js

+    return facts;
+  }
+
+  async advancePhase(challengeId, phases, operation, phaseName) {


How to identify correct phase if phase name is "Iterative Review"

eisbilir · 2023-05-18T07:49:36Z

src/phase-management/PhaseAdvancer.js

+      allSubmissionsReviewed: await this.#areAllSubmissionsReviewed(challengeId),
+    }),
+    "Iterative Review": async (challengeId) => ({
+      hasActiveUnreviewedSubmissions: await this.#hasActiveUnreviewedSubmissions(challengeId),


hasActiveUnreviewedSubmissions is for opening the phase.
for closing the phase, the fact should check if the earliest active submission has a committed review. there can be other active unreviewed submissions in the queue but they are ignored.

eisbilir · 2023-05-18T07:50:39Z

src/phase-management/phase-rules.json

+              "value": true
+            },
+            {
+              "fact": "hasActiveUnreviewedSubmissions",


need a different fact to check if the earliest active submission has enough commited review(s)

eisbilir · 2023-05-18T07:52:03Z

src/phase-management/phase-rules.json

+              "value": true
+            },
+            {
+              "fact": "isPastScheduledEndTime",


isPastScheduledEndTime or check if every submitters aggreed on early appeals

eisbilir · 2023-05-18T08:01:53Z

src/phase-management/phase-rules.json

+              "value": true
+            },
+            {
+              "fact": "isPastScheduledEndTime",


scheduled end time is not considered to close Appeals Response phase

eisbilir · 2023-05-18T08:08:28Z

src/phase-management/PhaseAdvancer.js

+      hasActiveUnreviewedSubmissions: await this.#hasActiveUnreviewedSubmissions(challengeId),
+    }),
+    Review: async (challengeId) => ({
+      allSubmissionsReviewed: await this.#areAllSubmissionsReviewed(challengeId),


There is another fact that checks if all test cases are uploaded If there is a development reviewer for challenge. But this could be something we are not doing anymore.

eisbilir · 2023-05-18T08:17:19Z

src/phase-management/phase-rules.json

+              "value": true
+            },
+            {
+              "fact": "isPastScheduledEndTime",


scheduled end time is not considered to close Review phase

eisbilir · 2023-05-18T08:24:04Z

src/phase-management/PhaseAdvancer.js

+  }
+
+  // prettier-ignore
+  #updateSubsequentPhases(phases, currentPhase, delta) {


If this is F2F, after submission phase is closed we shouldn't update iterative phases.

Signed-off-by: Rakib Ansary <[email protected]>

…e-advance

Signed-off-by: Rakib Ansary <[email protected]>

rakibansary and others added 14 commits May 1, 2023 20:55

fix: only sanitize html

495e4e6

Signed-off-by: Rakib Ansary <[email protected]>

Merge branch 'dev' into feature/edit-task-payment

40018d7

fix: enable read only root file system

8064a4e

Signed-off-by: Rakib Ansary <[email protected]>

fix: yarn not needed

4114f71

Signed-off-by: Rakib Ansary <[email protected]>

Merge branch 'dev' into feature/edit-task-payment

4acdf36

feat: add interfaces for fetching phase facts

6ce398e

Signed-off-by: Rakib Ansary <[email protected]>

ci: deploy to dev

e0448e0

Signed-off-by: Rakib Ansary <[email protected]>

fix: cyclic dependency

61436de

Signed-off-by: Rakib Ansary <[email protected]>

fix: success undefined

9b028f0

Signed-off-by: Rakib Ansary <[email protected]>

fix: success undefined

582b77f

Signed-off-by: Rakib Ansary <[email protected]>

feat: index challenge after advancing phase

d5aa181

Signed-off-by: Rakib Ansary <[email protected]>

fix: track, type is not needed

096334e

Signed-off-by: Rakib Ansary <[email protected]>

fix: use id from updated challenge

f1f38d6

Signed-off-by: Rakib Ansary <[email protected]>

fix: phase must be in open state before it can be closed

b3587de

Signed-off-by: Rakib Ansary <[email protected]>

eisbilir reviewed May 17, 2023

View reviewed changes

eisbilir reviewed May 18, 2023

View reviewed changes

rakibansary added 2 commits May 21, 2023 06:23

fix: include operation in next

711c2af

Signed-off-by: Rakib Ansary <[email protected]>

fix: phase name is sanitized

75bbf8a

Signed-off-by: Rakib Ansary <[email protected]>

rakibansary and others added 18 commits May 21, 2023 07:31

fix: use normalized phase name

229474d

Signed-off-by: Rakib Ansary <[email protected]>

fix: include additional facts in open phase operation

49a8e52

Signed-off-by: Rakib Ansary <[email protected]>

fix: submission phase closure check

d02fb6a

Merge branch 'dev' into feature/phase-advance

6715751

feat: add origin control

31cec39

ci: deploy to dev

43fe131

chore: use updated versions

267670f

Merge remote-tracking branch 'origin/fix/plat-2985' into feature/phas…

39c4ed1

…e-advance

wip: iterative review phase management

d9b55d1

Signed-off-by: Rakib Ansary <[email protected]>

fix: incorrect constraint name check

0b1ae00

wip: open next iterative review phase when appropriate

da0be50

Signed-off-by: Rakib Ansary <[email protected]>

fix: typo

724f458

fix: better handling of constraints

f761e06

fix: incorrect filter

6255831

fix: remove - from incoming phase name

cb574a0

Signed-off-by: Rakib Ansary <[email protected]>

feat: complete challenge on receiving winning submission

d4bf9f1

chore: add comment

4d3d794

Signed-off-by: Rakib Ansary <[email protected]>

fix: handle closing challenge when winner is found

b4d7b02

rakibansary merged commit a4bb399 into dev Jul 5, 2023

eisbilir deleted the feature/phase-advance branch September 16, 2023 10:49

feat: add phase management api #635

feat: add phase management api #635

Uh oh!

Conversation

rakibansary commented May 15, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eisbilir May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eisbilir May 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eisbilir May 17, 2023 •

edited

Loading

eisbilir May 18, 2023 •

edited

Loading