Fix/plat 2584 #610
Merged
Fix/plat 2584 #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakibansary
suggested changes
Mar 30, 2023
There was a problem hiding this comment.
Currently we don't take the response of the domainChallenge.delete() method - the response from the domain must be positive before we go ahead with deleting from ES. If there's an error from domain-challenge, it should be posted back to the user as an API response.
rakibansary
reviewed
Mar 30, 2023
src/services/ChallengeService.js
Outdated
| @@ -2282,6 +2282,9 @@ function sanitizeData(data, challenge) { | |||
| */ | |||
| async function deleteChallenge(currentUser, challengeId) { | |||
| const challenge = await challengeDomain.lookup(getLookupCriteria("id", challengeId)); | |||
There was a problem hiding this comment.
Let's use a scanCriteria here with
- id: challengeId
- status: New
We don't need to fetch a challenge that's not New.
rakibansary
reviewed
Mar 30, 2023
src/services/ChallengeService.js
Outdated
| await challengeDomain.delete(getLookupCriteria("id", challengeId)); | ||
| const { items: deletedItems } = await challengeDomain.delete(getLookupCriteria("id", challengeId)); | ||
| if (!_.find(deletedItems, { id: challengeId })) { | ||
| throw new errors.Internal(`There was an error deleting the challenge with id: ${challengeId} from dynamo`); |
There was a problem hiding this comment.
We don't need to specifically mention dynamo. Just that there was an error deleting the challenge with id ${challengeId} is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.