Fix/plat 2567 #605
Fix/plat 2567 #605
Conversation
| @@ -1589,6 +1589,18 @@ async function updateChallenge(currentUser, challengeId, data) { | |||
| logger.debug(`There was an error trying to update the project: ${e.message}`); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
We have the exact same check in another section. Let's avoid code duplication. Our last refactor extracted out common code to helper methods.
If the execution branch you introduced is different from the existing branch, the common code should move to a helper method with the different conditions at the top. For example
if (primaryConditionsAreSatisfied()) // chalengeStatuses in [ requirements infeasible, cancelled payment failed ]
if (conditionASatisfied() || conditionBSatisfied()) {
projectHelper.cancelProject()
}
This lets us immediately understand the conditions under which a project maybe cancelled. This commit introduces redundancy
There was a problem hiding this comment.
You're right! It introduces redundancy because I missed checking in the commit where I removed the duplicate code. Please check again
There was a problem hiding this comment.
We set the value of the variable isChallengeBeingCancelled but we never use it. Since the section you are updating has to do with challenge cancellation, we should double check if there's any need for isChallengeBeingCancelled and either add back functionality that we had before that we might have missed due to the refactor, or remove isChallengeBeingCancelled
No description provided.