Skip to content

Update phase population #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Update phase population #596

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5dc68d
fix: post mortem phase
eisbilir Mar 26, 2023
6014354
refactor phase populating
eisbilir Mar 27, 2023
62716f2
Merge pull request #582 from topcoder-platform/refactor/domain-challenge
eisbilir Mar 27, 2023
8426044
fix typo
ThomasKranitsas Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 56 additions & 34 deletions src/common/phase-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ class ChallengePhaseHelper {
}
const { timelineTempate } = await this.getTemplateAndTemplateMap(timelineTemplateId);
const { phaseDefinitionMap } = await this.getPhaseDefinitionsAndMap();
let fixedStartDate = undefined;
const finalPhases = _.map(timelineTempate, (phaseFromTemplate) => {
const phaseDefinition = phaseDefinitionMap.get(phaseFromTemplate.phaseId);
const phaseFromInput = _.find(phases, (p) => p.phaseId === phaseFromTemplate.phaseId);
Expand All @@ -184,14 +185,24 @@ class ChallengePhaseHelper {
actualEndDate: undefined,
};
if (_.isUndefined(phase.predecessor)) {
if (_.isUndefined(_.get(phaseFromInput, "scheduledStartDate"))) {
phase.scheduledStartDate = moment(startDate).toDate().toISOString();
} else {
phase.scheduledStartDate = moment(_.get(phaseFromInput, "scheduledStartDate")).toDate().toISOString();
let scheduledStartDate = _.defaultTo(
_.get(phaseFromInput, "scheduledStartDate"),
startDate
);
if (
!_.isUndefined(fixedStartDate) &&
moment(scheduledStartDate).isBefore(moment(fixedStartDate))
) {
scheduledStartDate = fixedStartDate;
}
phase.scheduledStartDate = moment(scheduledStartDate).toDate().toISOString();
phase.scheduledEndDate = moment(phase.scheduledStartDate)
.add(phase.duration, "seconds")
.toDate().toISOString();
.toDate()
.toISOString();
}
if (_.isUndefined(fixedStartDate)) {
fixedStartDate = phase.scheduledStartDate;
}
return phase;
});
Expand All @@ -202,14 +213,15 @@ class ChallengePhaseHelper {
const precedecessorPhase = _.find(finalPhases, {
phaseId: phase.predecessor,
});
if (phase.name === "Iterative Review Phase") {
if (phase.name === "Iterative Review") {
phase.scheduledStartDate = precedecessorPhase.scheduledStartDate;
} else {
phase.scheduledStartDate = precedecessorPhase.scheduledEndDate;
}
phase.scheduledEndDate = moment(phase.scheduledStartDate)
.add(phase.duration, "seconds")
.toDate().toISOString();
.toDate()
.toISOString();
}
return finalPhases;
}
Expand All @@ -224,65 +236,75 @@ class ChallengePhaseHelper {
timelineTemplateId
);
const { phaseDefinitionMap } = await this.getPhaseDefinitionsAndMap();

let fixedStartDate = undefined;
const updatedPhases = _.map(challengePhases, (phase) => {
const phaseFromTemplate = timelineTemplateMap.get(phase.phaseId);
const phaseDefinition = phaseDefinitionMap.get(phase.phaseId);
const newPhase = _.find(newPhases, (p) => p.phaseId === phase.phaseId);
const updatedPhase = {
...phase,
predecessor: phaseFromTemplate.predecessor,
predecessor: phaseFromTemplate && phaseFromTemplate.predecessor,
description: phaseDefinition.description,
};
if (!_.isUndefined(phase.actualEndDate)) {
return updatedPhase;
if (updatedPhase.name === "Post-Mortem") {
updatedPhase.predecessor = "a93544bc-c165-4af4-b55e-18f3593b457a";
}
if (updatedPhase.name === "Iterative Review Phase") {
return updatedPhase;
if (_.isUndefined(updatedPhase.actualEndDate) && updatedPhase.name !== "Iterative Review") {
updatedPhase.duration = _.defaultTo(_.get(newPhase, "duration"), updatedPhase.duration);
}
const newPhase = _.find(newPhases, (p) => p.phaseId === updatedPhase.phaseId);
if (_.isUndefined(newPhase) && !isBeingActivated) {
return updatedPhase;
}
updatedPhase.duration = _.defaultTo(_.get(newPhase, "duration"), updatedPhase.duration);
if (_.isUndefined(updatedPhase.predecessor)) {
let scheduledStartDate = _.defaultTo(
_.get(newPhase, "scheduledStartDate"),
updatedPhase.scheduledStartDate
);
if (
isBeingActivated &&
moment(
_.defaultTo(_.get(newPhase, "scheduledStartDate"), updatedPhase.scheduledStartDate)
).isSameOrBefore(moment())
!_.isUndefined(fixedStartDate) &&
moment(scheduledStartDate).isBefore(moment(fixedStartDate))
) {
scheduledStartDate = fixedStartDate;
}
if (isBeingActivated && moment(scheduledStartDate).isSameOrBefore(moment())) {
updatedPhase.isOpen = true;
updatedPhase.scheduledStartDate = moment().toDate().toISOString();
updatedPhase.actualStartDate = updatedPhase.scheduledStartDate;
} else if (
updatedPhase.isOpen === false &&
!_.isUndefined(_.get(newPhase, "scheduledStartDate"))
) {
updatedPhase.scheduledStartDate = moment(newPhase.scheduledStartDate).toDate().toISOString();
} else if (_.isUndefined(phase.actualStartDate)) {
updatedPhase.scheduledStartDate = moment(scheduledStartDate).toDate().toISOString();
}
updatedPhase.scheduledEndDate = moment(updatedPhase.scheduledStartDate)
.add(updatedPhase.duration, "seconds")
.toDate().toISOString();
.toDate()
.toISOString();
}
if (!_.isUndefined(newPhase) && !_.isUndefined(newPhase.constraints)) {
updatedPhase.constraints = newPhase.constraints;
}
if (_.isUndefined(fixedStartDate)) {
fixedStartDate = updatedPhase.scheduledStartDate;
}
return updatedPhase;
});
let iterativeReviewSet = false;
for (let phase of updatedPhases) {
if (_.isUndefined(phase.predecessor)) {
continue;
}
if (phase.name === "Iterative Review Phase") {
continue;
}
const precedecessorPhase = _.find(updatedPhases, {
const predecessorPhase = _.find(updatedPhases, {
phaseId: phase.predecessor,
});
phase.scheduledStartDate = precedecessorPhase.scheduledEndDate;
if (phase.name === "Iterative Review") {
if (!iterativeReviewSet) {
if (_.isUndefined(phase.actualStartDate)) {
phase.scheduledStartDate = predecessorPhase.scheduledStartDate;
}
iterativeReviewSet = true;
}
} else {
phase.scheduledStartDate = predecessorPhase.scheduledEndDate;
}
phase.scheduledEndDate = moment(phase.scheduledStartDate)
.add(phase.duration, "seconds")
.toDate().toISOString();
.toDate()
.toISOString();
}
return updatedPhases;
}
Expand Down