Skip to content

sortBy not working well #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luizrrodrigues opened this issue Oct 13, 2020 · 3 comments
Closed

sortBy not working well #326

luizrrodrigues opened this issue Oct 13, 2020 · 3 comments
Assignees

Comments

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Oct 13, 2020

@rootelement

Some sort option not working well:

prizeSets.prizes.value - Looks like this includes all values like Challenge Prize, Copilot and fees.
image


registrationEndDate - This is a know issue, because we have multiple Registration End date:

  • registrationEndDate (sort using this one)
  • phases['Registration'].actualEndDate
  • phases['Registration'].scheduledEndDate (looks like right one)
    image

submissionEndDate - Same here, we have multiple Submission End date:

  • registrationEndDate (sort using this one)
  • phases['Submission'].actualEndDate
  • phases['Submission'].scheduledEndDate (looks like right one)
    image
@luizrrodrigues
Copy link
Collaborator Author

@ThomasKranitsas
Copy link
Contributor

@rootelement this indeed needs some refactoring. I'm thinking, we should put all "informational" properties under an object like challenge.overview. Things like totalPrizes, startDate, endDate etc can go in there.

Thoughts?

@rootelement
Copy link
Contributor

This is fixed on the api side. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants