Skip to content

[$40] Add more Sort Options #4982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Sep 22, 2020 · 36 comments
Closed

[$40] Add more Sort Options #4982

SathyaJayabal opened this issue Sep 22, 2020 · 36 comments
Assignees
Labels
QA Pass in PROD Passed verification on Production tcx_Paid
Milestone

Comments

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Sep 22, 2020

We have only the sort by most recent and Title A-Z. Are we going to add the rest.

My Challenges:

  • Time to submit
  • number of registrants
  • number of submissions
  • Prize high to low

Open for Registration:

  • Time to Register
  • Time to Submit
  • number of registrants
  • number of submissions
  • Prize high to low

Ongoing Challenges:

  • Current Phase
  • Prize high to low
@SathyaJayabal
Copy link
Collaborator Author

@Oanh-and-only-Oanh Oanh-and-only-Oanh added New feature P4 Low (resolve within 2 weeks) labels Sep 22, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added this to the Release by 10/8/2020 milestone Sep 22, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Sort Options [$40] Add more Sort Options Sep 22, 2020
@Oanh-and-only-Oanh
Copy link

We can add the following:

My Challenges:
Time to submit
Prize high to low

Open for Registration:
Time to Register
Time to Submit
Prize high to low

Ongoing Challenges:
Current Phase
Prize high to low

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30143203 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/feature-refactor-challengelist
https://github.com/topcoder-platform/topcoder-react-lib/tree/feature-refactor-challengelist

run npm run test before PR

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30143203 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for crazyk via Topcoder X

@Oanh-and-only-Oanh
Copy link

@PrakashDurlabhji, please update with your progress.

@PrakashDurlabhji
Copy link
Contributor

@Oanh-and-only-Oanh @luizrrodrigues done in #5019

@luizrrodrigues
Copy link
Collaborator

@PrakashDurlabhji

image

@luizrrodrigues
Copy link
Collaborator

@PrakashDurlabhji Any status in this one?

@PrakashDurlabhji
Copy link
Contributor

@luizrrodrigues update you in few minutes

@PrakashDurlabhji
Copy link
Contributor

@luizrrodrigues PR is updated and console error is resolved.
Also making hit works but in response blank array is received hence unable backend api needs to be looked on which i hope is not a part of this ticket.

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Oct 8, 2020

@PrakashDurlabhji

My Challenges:

Most recent - OK
Time to submit - FAIL - used time-to-submit, this will works if use submissionEndDate
Prize high to low - FAIL - Please use sortBy=prizeSets.prizes.value
Title A - Z - OK

Open for Registration:

Most recent - OK
Time to Register - FAIL - used time-to-register, this will works if use registrationEndDate
Time to submit - FAIL - used time-to-submit, this will works if use submissionEndDate
Prize high to low - FAIL - Please use sortBy=prizeSets.prizes.value
Title A - Z - OK

Ongoing Challenges:

Most recent - OK
Current Phase - FAIL - Missing sortBy param
Prize high to low - FAIL - Please use sortBy=prizeSets.prizes.value
Title A - Z - OK

@ThomasKranitsas
Copy link
Contributor

@luizrrodrigues yes, that looks correct to me

@luizrrodrigues
Copy link
Collaborator

@ThomasKranitsas thanks for check, so looks like API not returning correct sort in both case, please check @SathyaJayabal screenshots above. (this deployed to Stag env: https://staging-community-app.topcoder.com/challenges)

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh You want go with prize sort only until we have API fixed? (I can hide Time to Register and Time to Submit for now.

@luizrrodrigues luizrrodrigues modified the milestones: v1.7.7, v1.8.0, v1.7.8 Feb 22, 2021
@SathyaJayabal SathyaJayabal removed this from the v1.7.8 milestone Feb 23, 2021
@Oanh-and-only-Oanh
Copy link

@luizrrodrigues, we're changing requirement here to add only by prize. We can ignore the other perimeters.

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh Okay cool, I'll update to hide Time to Register and Time to Submit

@luizrrodrigues luizrrodrigues added Ready for QA and removed Challenge API issue QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Feb 25, 2021
@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Deployed to Stag env.

@SathyaJayabal
Copy link
Collaborator Author

verified on staging
Screenshot 2021-02-25 at 11 32 43 AM
Screenshot 2021-02-25 at 11 33 34 AM
Screenshot 2021-02-25 at 11 34 04 AM

@SathyaJayabal
Copy link
Collaborator Author

verified on staging (develop branch)
Screenshot 2021-02-25 at 6 51 04 PM
Screenshot 2021-02-25 at 6 51 24 PM

Screenshot 2021-02-25 at 6 50 34 PM

@SathyaJayabal
Copy link
Collaborator Author

verified on prod.

Screenshot 2021-02-25 at 8 54 45 PM

Screenshot 2021-02-25 at 8 54 53 PM

Screenshot 2021-02-25 at 8 55 24 PM

@luizrrodrigues
Copy link
Collaborator

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for luizrrodrigues via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Pass in PROD Passed verification on Production tcx_Paid
Projects
None yet
Development

No branches or pull requests

6 participants