Skip to content

V5 to V4 Sync Issue: V5 Registrations and Submissions not seen in V4 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Jul 1, 2020 · 18 comments
Closed

V5 to V4 Sync Issue: V5 Registrations and Submissions not seen in V4 #204

SathyaJayabal opened this issue Jul 1, 2020 · 18 comments
Assignees
@rootelement
Labels
Beta Environment CF Retested community-app-integration Must-fix-before-v5-release P0 QA Pass Sync Issue

Comments

@SathyaJayabal
Copy link
Collaborator

Submissions or registrations made from V5 are not visible from V4.

Example:
https://beta-community-app.topcoder.com/challenges/6c0c6d56-fae9-4d41-8755-0482de5483f6
https://www.topcoder.com/challenges/30130748?tab=registrants

user picachui registered in V5 for the above challenge, but this is not reflected in V4.

cc @lakshmiathreya
@rootelement
Copy link
Contributor

There was an issue with the legacy-challenge-resource-processor putting registrations back into v4. Please retest @SathyaJayabal

@SathyaJayabal
Copy link
Collaborator Author

@rootelement , registrations made in V5 are not reflecting in V4.
https://beta-community-app.topcoder.com/challenges/9e68d9ca-912e-4848-b2b2-c9aad219da14?tab=registrants
https://www.topcoder.com/challenges/30131987?tab=registrants
Screenshot 2020-07-03 at 11 45 05 AM

Submissions made from v5 are also not reflecting in v4
https://beta-community-app.topcoder.com/challenges/0e19815e-fb7e-4a8c-bb52-6e5c6c101818?tab=submissions
https://www.topcoder.com/challenges/30108180?tab=submissions
Screenshot 2020-07-03 at 11 58 21 AM
Screenshot 2020-07-03 at 11 59 32 AM

cc @lakshmiathreya

@lakshmiathreya
Copy link

@rootelement @mtwomey - what @SathyaJayabal is trying to emphasize is the need for v4 and v5 to be in real time sync ... this would become critical once v5 goes to Prod as legacy Apps such as Direct and OR would continue to read off v4 ... we'd continue to depend on legacy Apps for Challenge Creation and Updates even after v5 goes to Prod ... cc @sushilshinde

This was referenced Jul 3, 2020
Closed
Closed
@lakshmiathreya lakshmiathreya changed the title V5 to V4 sync not working as expected V5 to V4 Sync Issue - V5 Registrations and Submissions not seen in V4 Jul 3, 2020
@lakshmiathreya lakshmiathreya changed the title V5 to V4 Sync Issue - V5 Registrations and Submissions not seen in V4 V5 to V4 Sync Issue : V5 Registrations and Submissions not seen in V4 Jul 3, 2020
@lakshmiathreya lakshmiathreya changed the title V5 to V4 Sync Issue : V5 Registrations and Submissions not seen in V4 V5 to V4 Sync Issue: V5 Registrations and Submissions not seen in V4 Jul 3, 2020
@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jul 6, 2020 •
edited
Loading

Submissions made from v5 are now reflecting in V4 and in OR after fix
topcoder-platform/submissions-api#179

Screenshot 2020-07-06 at 12 21 17 PM

Screenshot 2020-07-06 at 12 22 24 PM

@SathyaJayabal
Copy link
Collaborator Author

Registrations are still not synced form v5 to v4.

For example challenge "https://beta-community-app.topcoder.com/challenges/0e19815e-fb7e-4a8c-bb52-6e5c6c101818"
registered in v5 for customeruser/appirio123

This is not visible in OR
Screenshot 2020-07-06 at 4 14 52 PM
Screenshot 2020-07-06 at 4 15 20 PM

@SathyaJayabal SathyaJayabal mentioned this issue Jul 6, 2020
Closed
@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jul 7, 2020 •
edited
Loading

Also looks like submission were not seen in OR for some cases.
topcoder-platform/community-app#4629 (comment)

Unless registration is synced to V4, submissions also do not show up in OR.
#204 (comment)
The above case where submissions made from V5 are visible in OR is because the user is also registered to the challenge from V4

We can check this behaviour using the below steps:

  1. Register for a challenge in V5
  2. Submit for a challenge in V5
  3. You will not be able to access the OR page for this challenge
  4. Register to the same challenge in V4
  5. Access OR page for the challenge
  6. You will not be able to see the submission you made in step 2
  7. Submit again from v5
  8. Check OR again
  9. You will be able to see the submission you made in step 7

@mtwomey
Copy link

mtwomey commented Jul 10, 2020

@SathyaJayabal @sushilshinde Kindly retest the registration part today. James and I worked through this today and believe we have it working. I'm trying to test submissions - but I can't seem to submit at all right now (in beta), can you guys submit?

@SathyaJayabal
Copy link
Collaborator Author

@mtwomey , I am testing this right now. I was able to submit from beta.

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jul 10, 2020 •
edited
Loading

Registrations made from V5 reflecting in V4
Screenshot 2020-07-10 at 12 40 17 PM
Screenshot 2020-07-10 at 12 41 51 PM
Screenshot 2020-07-10 at 12 42 24 PM

Also received registration confirmation email.

@SathyaJayabal
Copy link
Collaborator Author

Submissions made from V5 are also reflecting in V4
Screenshot 2020-07-10 at 12 44 15 PM
Screenshot 2020-07-10 at 12 53 04 PM

Also received submission confirmation email

@SathyaJayabal
Copy link
Collaborator Author

@mtwomey @rootelement , strangely now, the registrations and submission made from v5 are not showing up in V5.(even though they show up in V4 (Prod and OR). The only place registration shows up in v5 is in the registrants table in challenge details.

Screenshot 2020-07-10 at 12 57 36 PM

Screenshot 2020-07-10 at 12 58 58 PM

@SathyaJayabal
Copy link
Collaborator Author

tracking challenge not showing up in my challenges here
#216

@mtwomey
Copy link

mtwomey commented Jul 10, 2020

@SathyaJayabal As per update on #216 @rootelement and I worked through this and think we're good here now. Please check on your end.

@mtwomey
Copy link

mtwomey commented Jul 11, 2020 •
edited
Loading

[All testing curls below are against the beta env "Adobe COVID Challenge Series" challenge (3cfa4e31-1758-4e65-aa73-61caa1d5154f / legacyId: 30132287)]

"numOfSubmissions": 0, is wrong in v5 challenge-api

Curl

curl --location --request GET 'https://api.topcoder.com/v5/challenges/3cfa4e31-1758-4e65-aa73-61caa1d5154f' \
--header 'Authorization: Bearer [M2M-TOKEN]'

Should return 1 submission. For comparison - current production uses this call

Curl

curl --location --request GET 'https://api.topcoder.com/v4/challenges/30132287' \
--header 'Authorization: Bearer [M2M-Token]'

and then it counts the number of members in the submissions array in the response. You can see there should be 1.

            "submissions": [
                {
                    "submitter": "mtwomey23",
                    "submitterId": 90002366,
                    "submissions": [
                        {
                            "submissionId": 384808,
                            "submissionStatus": "Active",
                            "submissionTime": "2020-07-10T21:08:25.000Z"
                        }
                    ]
                }
            ],

Also note - v5-submissions-api also has different results, showing 2 submissions here:

Curl

curl --location --request GET 'https://api.topcoder.com/v5/submissions?challengeId=3cfa4e31-1758-4e65-aa73-61caa1d5154f' \
--header 'Authorization: Bearer [M2M-Token]'

Result

[
    {
        "updatedBy": "mtwomey23",
        "created": "2020-07-10T21:08:25.447Z",
        "legacySubmissionId": 384808,
        "isFileSubmission": false,
        "type": "Contest Submission",
        "url": "https://s3.amazonaws.com/topcoder-submissions/02e14f95-59ca-4195-a002-f449886f49f7.zip",
        "challengeId": 30132287,
        "createdBy": "mtwomey23",
        "review": [
            {
                "score": 100,
                "updatedBy": "mL4037GVeLQOvb8TgU4KW38mlevpfp4y@clients",
                "reviewerId": "3ed22afd-2202-483a-b663-a676fec86b78",
                "submissionId": "02e14f95-59ca-4195-a002-f449886f49f7",
                "createdBy": "mL4037GVeLQOvb8TgU4KW38mlevpfp4y@clients",
                "created": "2020-07-10T21:08:31.472Z",
                "scoreCardId": 30001850,
                "typeId": "55bbb17d-aac2-45a6-89c3-a8d102863d05",
                "id": "c7134e67-b318-4879-a7ae-d9d7e46fc620",
                "updated": "2020-07-10T21:08:31.472Z",
                "status": "completed"
            }
        ],
        "id": "02e14f95-59ca-4195-a002-f449886f49f7",
        "submissionPhaseId": 1366828,
        "updated": "2020-07-10T21:08:25.447Z",
        "fileType": "zip",
        "memberId": 90002366
    },
    {
        "updatedBy": "picachui",
        "created": "2020-07-10T07:13:26.173Z",
        "legacySubmissionId": 384735,
        "isFileSubmission": false,
        "type": "Contest Submission",
        "url": "https://s3.amazonaws.com/topcoder-submissions/913d7489-7b53-4cfe-afc6-14fd65bd45f4.zip",
        "challengeId": 30132287,
        "createdBy": "picachui",
        "review": [
            {
                "score": 100,
                "updatedBy": "mL4037GVeLQOvb8TgU4KW38mlevpfp4y@clients",
                "reviewerId": "3258ff88-8a89-4f9f-811b-e4e0ae0564cd",
                "submissionId": "913d7489-7b53-4cfe-afc6-14fd65bd45f4",
                "createdBy": "mL4037GVeLQOvb8TgU4KW38mlevpfp4y@clients",
                "created": "2020-07-10T07:13:30.781Z",
                "scoreCardId": 30001850,
                "typeId": "55bbb17d-aac2-45a6-89c3-a8d102863d05",
                "id": "b0f2233d-bb5e-49bf-8fd5-1f116a728c68",
                "updated": "2020-07-10T07:13:30.781Z",
                "status": "completed"
            }
        ],
        "id": "913d7489-7b53-4cfe-afc6-14fd65bd45f4",
        "submissionPhaseId": 1366828,
        "updated": "2020-07-10T07:13:26.173Z",
        "fileType": "zip",
        "memberId": 22778049
    }
]

This might be just an issue with how submissions are deleted (possible by support?)

cc @rootelement

@rootelement
Copy link
Contributor

rootelement commented Jul 11, 2020 via email

@rootelement
Copy link
Contributor

rootelement commented Jul 11, 2020 via email

@SathyaJayabal
Copy link
Collaborator Author

@rootelement , the issue is not v4->v5 sync for submissions. But the submissions made from V5 is not showing up in the submissions count returned by the challenge api. The same submission is returned by the V4 challenge api and also the submissions api.

In the above example provided by @mtwomey , the submission in question is a submission made from V5.

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jul 13, 2020 •
edited
Loading

Let us track the submissions count issue separately.
#219
Registrations and submissions made from V5 are synced to v4.
#204 (comment)
#204 (comment)

@SathyaJayabal SathyaJayabal mentioned this issue Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootelement rootelement

Labels
Beta Environment CF Retested community-app-integration Must-fix-before-v5-release P0 QA Pass Sync Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rootelement @mtwomey @lakshmiathreya @SathyaJayabal