Merge branch 'dev' into CORE-40

Author: rakibansary

src/common/challenge-helper.js

@@ -375,8 +375,13 @@ class ChallengeHelper {
     }
 
     if (data.prizeSets != null) {
+      const type = data.prizeSets[0]?.prizes[0]?.type;
+      if (type === constants.prizeTypes.USD) {
+        ChallengeHelper.convertPSValuesToCents(data.prizeSets)
+      }
+      
       data.prizeSetUpdate = {
-        prizeSets: data.prizeSets,
+        prizeSets: [...data.prizeSets],
       };
       delete data.prizeSets;
     }
@@ -484,12 +489,7 @@ class ChallengeHelper {
     }
   }
 
-  convertToISOString(startDate) {
-    return ChallengeHelper.convertDateToISOString(startDate);
-  }
-
-  // TODO: Deprecate this method
-  convertPrizeSetValuesToCents(prizeSets) {
+  static convertPSValuesToCents(prizeSets){
     prizeSets.forEach((prizeSet) => {
       prizeSet.prizes.forEach((prize) => {
         prize.amountInCents = new Decimal(prize.value).mul(100).toNumber();
@@ -498,7 +498,14 @@ class ChallengeHelper {
     });
   }
 
-  // TODO: Deprecate this method
+  convertToISOString(startDate) {
+    return ChallengeHelper.convertDateToISOString(startDate);
+  }
+
+  convertPrizeSetValuesToCents(prizeSets) {
+    return ChallengeHelper.convertPSValuesToCents(prizeSets);
+  }
+
   convertPrizeSetValuesToDollars(prizeSets, overview) {
     prizeSets.forEach((prizeSet) => {
       prizeSet.prizes.forEach((prize) => {

src/services/ChallengeService.js

@@ -1909,9 +1909,7 @@ async function updateChallenge(currentUser, challengeId, data) {
         `Cannot change prize type from ${existingPrizeType} to ${newPrizeType}`
       );
     }
-    if (updateInput.prizeSetUpdate != null && newPrizeType === constants.prizeTypes.USD) {
-      convertPrizeSetValuesToCents(updateInput.prizeSetUpdate.prizeSets);
-    }
+
     await challengeDomain.update(
       {
         filterCriteria: getScanCriteria({ id: challengeId }),