Skip to content

Commit 5c8cdc7

Browse files
authored
Merge pull request #694 from topcoder-platform/hotfix/budget-update
fix: send amountInCents when doing challenge update
2 parents 3a1893f + 66a1872 commit 5c8cdc7

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ workflows:
9090
branches:
9191
only:
9292
- dev
93-
- PLAT-3491
93+
- hotfix/budget-update
9494

9595
- "build-qa":
9696
context: org-global

src/common/challenge-helper.js

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -356,9 +356,12 @@ class ChallengeHelper {
356356
}
357357

358358
if (data.prizeSets != null) {
359+
ChallengeHelper.convertPSValuesToCents(data.prizeSets)
360+
console.log('Converted prizeSets to cents', data.prizeSets)
359361
data.prizeSetUpdate = {
360-
prizeSets: data.prizeSets,
362+
prizeSets: [...data.prizeSets],
361363
};
364+
console.log('prizeSetUpdate', data.prizeSetUpdate)
362365
delete data.prizeSets;
363366
}
364367

@@ -465,11 +468,7 @@ class ChallengeHelper {
465468
}
466469
}
467470

468-
convertToISOString(startDate) {
469-
return ChallengeHelper.convertDateToISOString(startDate);
470-
}
471-
472-
convertPrizeSetValuesToCents(prizeSets) {
471+
static convertPSValuesToCents(prizeSets){
473472
prizeSets.forEach((prizeSet) => {
474473
prizeSet.prizes.forEach((prize) => {
475474
prize.amountInCents = new Decimal(prize.value).mul(100).toNumber();
@@ -478,6 +477,14 @@ class ChallengeHelper {
478477
});
479478
}
480479

480+
convertToISOString(startDate) {
481+
return ChallengeHelper.convertDateToISOString(startDate);
482+
}
483+
484+
convertPrizeSetValuesToCents(prizeSets) {
485+
return ChallengeHelper.convertPSValuesToCents(prizeSets);
486+
}
487+
481488
convertPrizeSetValuesToDollars(prizeSets, overview) {
482489
prizeSets.forEach((prizeSet) => {
483490
prizeSet.prizes.forEach((prize) => {

src/services/ChallengeService.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1890,9 +1890,6 @@ async function updateChallenge(currentUser, challengeId, data) {
18901890
grpcMetadata.set("userId", currentUser.userId);
18911891
grpcMetadata.set("token", await getM2MToken());
18921892

1893-
if (updateInput.prizeSetUpdate != null) {
1894-
convertPrizeSetValuesToCents(updateInput.prizeSetUpdate.prizeSets);
1895-
}
18961893
await challengeDomain.update(
18971894
{
18981895
filterCriteria: getScanCriteria({ id: challengeId }),

0 commit comments

Comments
 (0)