Skip to content
This repository was archived by the owner on Mar 12, 2025. It is now read-only.

For #11 and #12 #13

Merged
merged 2 commits into from
Dec 6, 2019
Merged

For #11 and #12 #13

merged 2 commits into from
Dec 6, 2019

Conversation

dhruvit-r
Copy link
Contributor

@dhruvit-r dhruvit-r commented Dec 6, 2019 •
edited by sharathkumaranbu
Loading

Fixes #11 and #12

@dhruvit-r dhruvit-r mentioned this pull request Dec 6, 2019
Closed
callmekatootie
callmekatootie suggested changes Dec 6, 2019
View reviewed changes
@dhruvit-r
Copy link
Contributor Author

@cwdcwd Done.

@sharathkumaranbu
Copy link
Collaborator

@dhruvit-r Could you update the package.json with this tag https://github.com/appirio-tech/tc-core-library-js/releases/tag/v2.6.4 to resolve #11 as well?

@dhruvit-r
Copy link
Contributor Author

@sharathkumaranbu Done.

@dhruvit-r dhruvit-r changed the title For #12: Add option to stream a download For #11 and #12 Dec 6, 2019
sharathkumaranbu
sharathkumaranbu approved these changes Dec 6, 2019
View reviewed changes
Copy link
Collaborator

@sharathkumaranbu sharathkumaranbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Verified the usage in Topcoder CLI as well.

@sharathkumaranbu sharathkumaranbu merged commit ca0a2ab into topcoder-archive:develop Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sharathkumaranbu sharathkumaranbu sharathkumaranbu approved these changes

@callmekatootie callmekatootie Awaiting requested review from callmekatootie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security vulnerability in API wrapper
3 participants
@dhruvit-r @sharathkumaranbu @callmekatootie