Skip to content
This repository was archived by the owner on Mar 12, 2025. It is now read-only.

Add PUT endpoint for both skills and taxonomies #12

Closed
SathyaJayabal opened this issue Aug 16, 2021 · 5 comments
Closed

Add PUT endpoint for both skills and taxonomies #12

SathyaJayabal opened this issue Aug 16, 2021 · 5 comments
Labels
Milestone

Comments

@SathyaJayabal
Copy link
Collaborator

Add PUT endpoint for both skills and taxonomies

@SathyaJayabal SathyaJayabal added the p1 high priority issues label Aug 16, 2021
@vikasrohit vikasrohit added the Ready for Dev QA Ready for QA in dev environment label Aug 18, 2021
@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Aug 18, 2021

We get the following error when we do not have new values for name or taxonomyId fields. This will not allow you to update the record unless you change one of the two fields. Note same issue exists on PATCH.
{ "message": "Skill already exists with taxonomyId:9cc0795a-6e12-4c84-9744-15858dba1861, name:jump6" }

Screenshot 2021-08-18 at 5 33 51 PM

@SathyaJayabal SathyaJayabal added QA Fail in Dev and removed Ready for Dev QA Ready for QA in dev environment labels Aug 18, 2021
@SathyaJayabal
Copy link
Collaborator Author

Note: This is issue is not found in the taxonomies endpoint (PUT and PATCH)

@Sande3p Sande3p added Ready for Dev QA Ready for QA in dev environment and removed QA Fail in Dev labels Aug 19, 2021
@sandhiyakavi
Copy link
Collaborator

Verified in Dev Env.

PUT endpoint for skills is now allowing us to update even though the name and taxonomy id are not changed.
image

PUT endpoint for taxonomy is working fine as expected.
image

@sandhiyakavi sandhiyakavi added QA Pass in Dev and removed Ready for Dev QA Ready for QA in dev environment labels Aug 19, 2021
@sandhiyakavi
Copy link
Collaborator

The same is working for PATCH endpoints of Skills and taxonomies as well.

image
image

@vikasrohit vikasrohit added the Ready for Prod QA Ready for QA in prod environment label Aug 19, 2021
@SathyaJayabal SathyaJayabal added this to the v1.0.0 milestone Aug 19, 2021
@SathyaJayabal SathyaJayabal added QA Pass in Prod and removed Ready for Prod QA Ready for QA in prod environment labels Aug 19, 2021
@SathyaJayabal
Copy link
Collaborator Author

verified on prod
Screenshot 2021-08-19 at 6 32 20 PM
Screenshot 2021-08-19 at 6 32 02 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants