Skip to content
This repository was archived by the owner on Mar 12, 2025. It is now read-only.

Updates from another repo 1 #6

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Conversation

maxceem
Copy link
Contributor

@maxceem maxceem commented Oct 31, 2019

I've disabled RabbitMQ handlers which call ES indexing which we are doing now inside "project-processor-es".

But I still keep the code at the moment, it's just disabled.

Also, some other misc fixes.

See the detailed list of commits in another repo:

image

- fix: removed duplicate ES index calls
- feat: bring back RabbitMQ unit tests for works
- refactor: simpler code to wait before test
@maxceem maxceem requested a review from vikasrohit October 31, 2019 06:56
@vikasrohit
Copy link

@maxceem this PR also contains more ES related changes like ES indexing tests for Work and related model, right?

@maxceem
Copy link
Contributor Author

maxceem commented Oct 31, 2019

@maxceem this PR also contains more ES related changes like ES indexing tests for Work and related model, right?

Hmm, they are not supposed to be here. Actually, other changes have been already merged, not sure why they are still shown as a part of PR.

I'll try to create another PR without these changes.

@maxceem maxceem closed this Oct 31, 2019
@maxceem maxceem reopened this Oct 31, 2019
@maxceem maxceem changed the title Disabled duplicate ES index calls by RabbitMQ Updates from another repo 1 Oct 31, 2019
@maxceem
Copy link
Contributor Author

maxceem commented Oct 31, 2019

@vikasrohit This PR contains updates which have been done in another repo:

image

As repositories are different, I just copy/paste changes from another repo and push them here as one commit. For a detailed history, we should use the old repo https://github.com/topcoder-platform/tc-project-service/commits/v5-upgrade as I keep the history there.

@vikasrohit vikasrohit merged commit fcb673b into topcoder-archive:develop Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants