This repository was archived by the owner on Mar 13, 2025. It is now read-only.
feat(search-boxes): add clear button for inputs #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add clear/reset button for the searchBox component input. Add clear/reset button for the SuggestionBox component input. Addresses topcoder-archive#161
callmekatootie
suggested changes
Jul 26, 2020
There was a problem hiding this comment.
In General
- The clear search text is not showing in Add To Group modal
In Firefox
- The clear search text button is not vertically centered (I think this is applicable to chrome too not sure if it is really at center) but in firefox it is definitely prominent that it is not vertically centered
- In the Group tab, the clear search text does not show up. It does show up in Chrome
Fix for the vertical alignment of the clear buttons at search inputs. Add the missing clear/reset button for the AddToGroupModal.
|
@callmekatootie Pushed a new commit, it should solve the mentioned issues |
callmekatootie
approved these changes
Jul 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clear/reset button for the searchBox component input.
Add clear/reset button for the SuggestionBox component input.
Add clear/reset button for the AddToGroupModal component input.
Addresses #161