This repository was archived by the owner on Mar 13, 2025. It is now read-only.
Fix issue 17 #578
Merged
Fix issue 17 #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…als fully visible.
callmekatootie
suggested changes
Jul 25, 2020
There was a problem hiding this comment.
See attached GIF:
First view is from my local dev with your changes. Second is from what currently exists. The issues are:
- The left alignment of the right column section is not what it was before
- There's no padding / spacing at the bottom of the modal...
Note that this is Google Chrome / Firefox itself - yet to review in IE11. But let's first ensure that this is working fine in Chrome / Firefox itself
No issues found with the Group and Filter modals... (in Chrome / Firefox)
|
@callmekatootie . Okay, I have started to work on this issues. |
…le Modal' and padding at the bottom of the modal.
|
@callmekatootie I have fixed this issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fix issue #17, 'Add to Group', 'Manage Filters' and 'Edit Profile' modals fully visible.