This repository was archived by the owner on Mar 13, 2025. It is now read-only.
fixes issue#66 #568
Merged
fixes issue#66 #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romitgithub The previous PR was not merged since it did not fix the issue - you have to submit all the changes, in this case, the changes in the Search page too... |
|
@romitgithub Sorry but the changes are not fine - the scroll happens AFTER the results appear - the scroll should happen when search is invoked... That is, if I change the page number, it should immediately scroll to the top... |
|
@callmekatootie The issue is on Global Search Page only, right? The groups page is fine? |
|
I would say no - even the groups page needs the scroll to happen before the search starts... Right now, the members load and then the scroll happens... |
|
@callmekatootie Done. It scrolls before loading members now in both pages. Please verify. Thanks |
callmekatootie
approved these changes
Jul 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#66