Fix logout dropdown hide on outside click

[sanjiv-saini]

#45

[callmekatootie]

Before fix:

After fix:

There's a bolder outline...

[callmekatootie]

#565 (comment)

[sanjiv-saini]

That is because, earlier that dropdown was not getting focused, thats the behaviour of focus. It will work in accessibility behaviour as well, like going through tab hitting tab will focus the dropdown itself. @callmekatootie

[callmekatootie]

That is because, earlier that dropdown was not getting focused, thats the behaviour of focus. It will work in accessibility behaviour as well, like going through tab hitting tab will focus the dropdown itself.

Ok. But we are not expecting any focus to happen - the expectation is that the dropdown closes when clicked outside. It should not have any side effects

[sanjiv-saini]

This is the only clean solution I found. others require event on top document, and may not work always. @callmekatootie . Here the side effect is in the correct way. Because what you asking is when ever user focus goes out of that dropdown, it should close. thats the behaviour it is doing. Earlier that was not the case.

[callmekatootie]

I see. Could we then disable the outline using CSS when the element is in focus...

[sanjiv-saini]

ok, I will update the css.

[callmekatootie]

@sanju-singh Is this ready for review again... (If so, remove the Feedback label to get my attention 😊 )

[sanjiv-saini]

@callmekatootie , yes, I updated in issue, forgot to update here. Thanks