Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

issue 102 fix #560

Merged
merged 2 commits into from
Jul 24, 2020
Merged

issue 102 fix #560

merged 2 commits into from
Jul 24, 2020

Conversation

PrakashDurlabhji
Copy link
Contributor

@PrakashDurlabhji PrakashDurlabhji commented Jul 23, 2020 •
edited by callmekatootie
Loading

@PrakashDurlabhji PrakashDurlabhji mentioned this pull request Jul 23, 2020
Closed
callmekatootie
callmekatootie suggested changes Jul 24, 2020
View reviewed changes
Copy link
Collaborator

@callmekatootie callmekatootie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work.

The expectation as mentioned in the ticket:

Expected: The Sort by dropdown should close when user clicks ANYWHERE on the page if it is open

Your solution closes the modal only if a search is carried out...

@callmekatootie callmekatootie merged commit 120fad5 into develop Jul 24, 2020
@callmekatootie callmekatootie deleted the issue_102 branch July 24, 2020 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@callmekatootie callmekatootie callmekatootie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PrakashDurlabhji @callmekatootie