Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$125] Changing the isAvailable attribute value is not changing the actual status #85

Closed
Vips19 opened this issue Jul 12, 2020 · 17 comments
Assignees
Labels
bug Something isn't working medium priority Not a roadblock to release but must be addressed at some point tcx_Assigned tcx_FixAccepted tcx_Paid

Comments

@Vips19
Copy link
Collaborator

Vips19 commented Jul 12, 2020

Screenshots
Screenshot (344)

Reproduction Steps:

Open the Application https://skill-search.topcoder-dev.com/
Click Topcoder > Go to first tab
Click Click Edit for User Brady Swift
Now change the isAvailable custom attribute and check the status is changing or not

Actual Result: Changing the custom attribute is not changing the actual status of the user

Expected Result: Changing the custom attribute must change the actual status of the user

Device/OS: Laptop | Windows 8.1 (64bit)

Browser Information: IE11,Chrome,Firefox

@callmekatootie
Copy link
Collaborator

Good catch. Let me check if the two are the same attributes or not and get back

@callmekatootie
Copy link
Collaborator

Will take this as a bug - the attribute should NOT have been seen here because it already has a UI element and not meant for custom attributes section.. Applicable to other attributes too for which we already have other ui elements

@wdprice
Copy link

wdprice commented Jul 20, 2020

@callmekatootie confirming that I believe availability should not appear in custom attributes

@wdprice wdprice added the medium priority Not a roadblock to release but must be addressed at some point label Jul 20, 2020
@wdprice wdprice added this to the v1.0 - Initial Launch milestone Jul 20, 2020
@callmekatootie callmekatootie self-assigned this Jul 21, 2020
@callmekatootie callmekatootie changed the title Changing the isAvailable attribute value is not changing the actual status [$75] Changing the isAvailable attribute value is not changing the actual status Jul 25, 2020
@callmekatootie
Copy link
Collaborator

Expected:

We currently have the following four environment variables used by front end:

  • REACT_APP_ATTRIBUTE_ID_LOCATION
  • REACT_APP_ATTRIBUTE_ID_COMPANY
  • REACT_APP_ATTRIBUTE_ID_TITLE
  • REACT_APP_ATTRIBUTE_ID_ISAVAILABLE

Currently, the point to GUIDs. Instead, we intend to update them to use the following values:

  • REACT_APP_ATTRIBUTE_ID_LOCATION='location'
  • REACT_APP_ATTRIBUTE_ID_COMPANY='company'
  • REACT_APP_ATTRIBUTE_ID_TITLE='title'
  • REACT_APP_ATTRIBUTE_ID_ISAVAILABLE='isAvailable'

Task 1
When the landing page loads, the user is prompted to select the org. We then proceed to fetch the attribute groups for that org (https://api.topcoder-dev.com/v5/attributeGroups?organizationId=<the_selected_org_id>) followed by fetching the attributes in each of the attribute groups (https://api.topcoder-dev.com/v5/attributes?attributeGroupId=).

At this point, isolate the "standard user attributes" and the "company attributes". Standard user attributes are the ones defined in the above env variables (we will be defining their name as seen above - currently, we defined their GUID which will be replaced with the name instead). The company attributes are already being isolated - isolate the standard attributes too. Isolate here means identify - just like how we identify the company attributes (and display them in the Manage Filters modal).

The relevant code is here. At least I think that is the code - PLEASE VERIFY before you proceed with the fix.

Task 2
Having identified the primary attributes (particularly their ids), you will then proceed to use it at all locations where we earlier used the standard user attributes. That is, earlier, we used the ids of the attributes in the code - you will now use the ids too, but only after first identifying them through Task 1.

This will ensure that the standard user attributes DO NOT show up in the Edit Profile modal, under the custom attributes section

This also means that you would need to ensure that you first fetch the attributes AFTER which you will then carry out the search

For your testing, you could instead use the names of the existing custom attributes instead (gender, experience etc) and verify that they are not showing up in the Custom attributes section (and the filter).

PLEASE PROCEED WITH CARE This is a critical issue of the app and thus, please make sure that any changes that you do are not having any side effects

@callmekatootie callmekatootie changed the title [$75] Changing the isAvailable attribute value is not changing the actual status [$125] Changing the isAvailable attribute value is not changing the actual status Jul 25, 2020
@callmekatootie callmekatootie removed their assignment Jul 25, 2020
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2020

Contest https://www.topcoder.com/challenges/30134274 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2020

Contest https://www.topcoder.com/challenges/30134274 has been updated - it has been assigned to callmekatootie.

This is an automated message for lazybaer via Topcoder X

@callmekatootie
Copy link
Collaborator

This ticket is open for pickup

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2020

Contest https://www.topcoder.com/challenges/30134274 has been updated - it has been assigned to Timor.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2020

Contest https://www.topcoder.com/challenges/30134274 has been updated - it has been assigned to Narekvar90.

This is an automated message for lazybaer via Topcoder X

@callmekatootie
Copy link
Collaborator

@narekcat This one's another critical issue... Also I understand the effort involved so you can take 36 hours more if needed (assuming you do intend to submit a solution)

@narekcat
Copy link
Contributor

@callmekatootie . Ok, I am actively working on this issue. Thank you for additional hours. I'll submit my solution in time.

@narekcat
Copy link
Contributor

@callmekatootie . I approximately finished this issue, but I have a question. Need I show 'General Attributes' in 'Manage Filters Modal' or 'General Attributes' must be replaced with 'Standard Attributes'?

@callmekatootie
Copy link
Collaborator

@narekcat You mean the title of the section? The current one is fine... I just referred it as Standard attributes because the code did (and the UI called it General instead 🤷‍♂️ )

@narekcat
Copy link
Contributor

@callmekatootie One more question. How I must get suggestion data for Company and Title. Can I mock that data like Locations and Achievements or I must add endpoint to back end like skills ?

@callmekatootie
Copy link
Collaborator

Company and title will NOT be part of the filters - so no suggestion is needed... I realize that I described it such that you would believe that these need to show up in the standard / general attribute filters - but they will not... they are standard / general attributes, but we will not have any filters for them...

@narekcat
Copy link
Contributor

@callmekatootie . I have fixed this issue. Please see pull request #612.

callmekatootie added a commit that referenced this issue Jul 27, 2020
Fix issue #85, isolate standard user attributes from company attributes.
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 27, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30134274

This is an automated message for lazybaer via Topcoder X

cagdas001 pushed a commit to cagdas001/u-bahn-app that referenced this issue Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working medium priority Not a roadblock to release but must be addressed at some point tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Development

No branches or pull requests

6 participants