-
Notifications
You must be signed in to change notification settings - Fork 5
[$300] Project UBahn | Update Login to use accounts.topcoder.com #630
Comments
Note to self - check out Laushcer or Vorbote for how we did this... |
@cwdcwd Is this available on npm - https://github.com/appirio-tech/accounts-app ? Lauscher seems to have copied code from this repo (some minification issues). Need to know if I should go the same way in this app or if there's a module that I can make use of... |
let's loop in @sachin-maheshwari for how best to incorporate the new login stuff. @sachin-maheshwari can we publish the new login component to npm for inclusion in our apps? |
@cwdcwd I am investigating, will share my thoughts. |
As i explored I think, we need to authenticate and authorize in this way - https://github.com/appirio-tech/connect-app/blob/test/auth0lib/src/components/AuthenticatedComponent.jsx In general, for authentication, currently we are using account-app (that is authenticating and setting topcoder cookies (JWT tokens) in browsers). In authorization, we have common logic(lib) to read and validate that cookies (JWT token). For example - "New Auth Flow" https://github.com/topcoder-platform/tc-auth-lib/blob/dev/src/connector-wrapper.js#L68 |
I think, in this app we are doing like - Authentication - https://github.com/topcoder-platform/u-bahn-app/blob/develop/client/src/react-auth0-spa.js#L48 |
@sachin-maheshwari are any of these pieces publishable via npm as modules so we can drop them into our code easily? |
@cwdcwd no exactly, but can include like this - |
I'm not a big fan or references by git url. Can I add a github action to publish |
You can publish but some code clean-up required (like web-assets folder not related to this and iframe and refresh token logic). |
that's fine. we'll just do another release once that happens.I'll add a github action to publish |
Bump. Just checking in if we have the module to use |
@sachin-maheshwari do you care if I change the package to be |
@sachin-maheshwari I made a PR here for this |
NP, I'll take care. Thanks! |
thanks @sachin-maheshwari ! |
Contest https://www.topcoder.com/challenges/30143227 has been created for this ticket. |
@ all Ticket OPEN FOR PICKUP Task Details:
|
Contest https://www.topcoder.com/challenges/30143227 has been updated - it has been assigned to Narekvar90. |
@narekcat Just a FYI - the outcome of your changes will result in the user being redirected to accounts.topcoder(-dev).com and not to auth0 if they are not logged in. You can visit http://lauscher.topcoder-dev.com/ to get an idea about how the app behaves when we use accounts.topcoder for login instead of auth0 (Laushcer is a different app - only mentioning it here to give you a reference of how to integrate with accounts.topcoder instead of auth0) |
@callmekatootie Okay. |
@callmekatootie I am actively working on this issue, I just need additional 24 hours to finish it. Is it ok ? |
I understand. No worries. |
Thanks. |
@callmekatootie Hi, I am still actively working on this issue, but it is much harder then I thought. I need more time to finish it. What you think about that ? |
Should be fine - however, I hope you will submit in the next 24 hours else I will have to explore other options |
I'll do my best to finish it in time, if I couldn't I'll put it back. |
@narekcat Status check |
My bad. Didn't see you marked it as open for pickup |
Contest https://www.topcoder.com/challenges/30143227 has been updated - callmekatootie has been unassigned. |
Contest https://www.topcoder.com/challenges/30143227 has been updated - it has been assigned to callmekatootie. |
Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30143227 |
currently login flow goes through topcoder.auth0.com
Need to use accounts.topcoder.com for proper cross-site platform handling.
The text was updated successfully, but these errors were encountered: