[$75] Horizontal scrollbar in IE11 for Add To Group modal

[callmekatootie]

Follow up of #155

From the changes in that ticket, we are now seeing a horizontal scrollbar in the Add To Group modal - in IE11 browser.

Expected - we should NOT see the horizontal scrollbar in the Add To Group modal. Virtual scrolling should continue to work as before as so should all other features.

[callmekatootie]

Ticket open for pickup - please pick it up only if you can provide a solution within 2 hours

[cwdcwd]

Contest https://www.topcoder.com/challenges/30135238 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

[cwdcwd]

Contest https://www.topcoder.com/challenges/30135238 has been updated - it has been assigned to genycopedison.

This is an automated message for lazybaer via Topcoder X

[callmekatootie]

@phongnt There's an extra gap on the right for the modal:

If it helps, the scrollbar need not be to just the OTHER GROUPS, you can also attach the scrollbar to the entire groups modal, (except the header - ADD TO GROUP, which will always be seen)

[phongnt]

@phongnt There's an extra gap on the right for the modal:

If it helps, the scrollbar need not be to just the OTHER GROUPS, you can also attach the scrollbar to the entire groups modal, (except the header - ADD TO GROUP, which will always be seen)

@callmekatootie Sorry I don't get your point. Do you mean add scrollbar for MY GROUP?

[phongnt]

I got your point now, let me fix it

[callmekatootie]

@phongnt How's it looking - if you are not able to arrive at a solution, we can open it up for others to work on...

[phongnt]

Give me 30 min

[cwdcwd]

Contest https://www.topcoder.com/challenges/30135238 has been updated - it has been assigned to Narekvar90.

This is an automated message for lazybaer via Topcoder X

[narekcat]

@callmekatootie I have fixed this issue. Please see pull request #623.

[cwdcwd]

Contest https://www.topcoder.com/challenges/30135238 has been updated - it has been assigned to kingszlayer.

This is an automated message for lazybaer via Topcoder X

[venkygot]

@callmekatootie Going thru the trail I'm little confused. What needs to be fixed here? I don't see horizontal scrollbar in IE11. See below.

[callmekatootie]

@venkygot Weird. I do not see it anymore either... I see what you are seeing above

Yet, it is not fine - remove the two scrollbars to have just one. Either have a single scrollbar for the entire modal (except the header title and footer buttons) or keep scrollbar for the individual sections (MY GROUPS and OTHER GROUPS) is what we are looking for...

[callmekatootie]

This is what I used to see initially - #155 (comment)

[cagdas001]

@callmekatootie Since you merged the #622 , there is a commit from it that plays with the min-width of the modal. That's the change that removes horizontal scroll but leaves some gaps as you mentioned at the feedback of this PR #621 (comment)

[callmekatootie]

Reverting the changes - checking if that was indeed it

[cagdas001]

remove the two scrollbars to have just one. Either have a single scrollbar for the entire modal (except the header title and footer buttons) or keep scrollbar for the individual sections (MY GROUPS and OTHER GROUPS) is what we are looking for...

You're currently not seeing a scrollbar for the My Groups list, because it currently have only 3 items. If it'd have more items (>10), there will be a scrollbar for it as well

https://github.com/topcoder-platform/u-bahn-app/blob/08573f5caaac3440d3548ccd35bb35c2f635ae7f/client/src/components/AddToGroupModal/index.jsx#L245-L249

Two lists are indeed independent & individual virtual lists, so with a single scrollbar for both you'll not have control on individual lists, but on all the modal (btw you also need to merge two lists and serve all items as a single list for this but this is another point)

[callmekatootie]

Fair point - In which case, you can have individual scrollbars for the sections - that is acceptable too

[venkygot]

@callmekatootie so I need to pull the updated code from develop and proceed? or continue with what I have?

[callmekatootie]

Pull updated code and proceed

[callmekatootie]

@venkygot Any update here - if you are not working on the ticket actively, could you kindly open it up for others to take a chance

[venkygot]

@callmekatootie will submit PR shortly

[cwdcwd]

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for lazybaer via Topcoder X

[cwdcwd]

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for lazybaer via Topcoder X

[cwdcwd]

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30135238

This is an automated message for lazybaer via Topcoder X