Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$30] Adding empty or deleting empty filters is making "Users" requests again #524

Closed
greenmug-md opened this issue Jul 14, 2020 · 19 comments
Assignees
Labels
bug Something isn't working medium priority Not a roadblock to release but must be addressed at some point tcx_Assigned tcx_FixAccepted tcx_Paid

Comments

@greenmug-md
Copy link

Video : https://drive.google.com/file/d/1v7ueEqqMewMc69Bv7-Q-RZ98IuD5JDZe/view?usp=sharing

Reproduction Steps:
1. Open the Application https://skill-search.topcoder-dev.com/
2. Click Topcoder > Go to the Tab 01 (Users)
3. Add or Delete empty filter, without any particular criteria.
4. User Request is being made while adding empty filters

Expected Result: Add empty or deleting filters should not be making user request, only should be made when we are adding valid criteria

Device/OS: Laptop | MACOS (64bit)
Browser Information: Chrome 83.0.4103.116 | Firefox 78.0.2 | IE11

@callmekatootie
Copy link
Collaborator

valid bug

@callmekatootie callmekatootie added the bug Something isn't working label Jul 17, 2020
@wdprice wdprice added this to the v1.0 - Initial Launch milestone Jul 20, 2020
@wdprice wdprice added the medium priority Not a roadblock to release but must be addressed at some point label Jul 20, 2020
@callmekatootie callmekatootie changed the title [Bug Hunt] Adding empty or deleting empty filters is making "Users" requests again [$20] Adding empty or deleting empty filters is making "Users" requests again Jul 21, 2020
@callmekatootie
Copy link
Collaborator

Expected:

  • When adding a filter section, we should not perform the search again
  • When removing a filter section, ONLY IF that filter section had active filters, we will perform the search again - with the active filters removed. Else, we don't need to search again

@callmekatootie callmekatootie changed the title [$20] Adding empty or deleting empty filters is making "Users" requests again [$30] Adding empty or deleting empty filters is making "Users" requests again Jul 21, 2020
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 23, 2020

Contest https://www.topcoder.com/challenges/30133978 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@codingdrone
Copy link

working on it.

@callmekatootie
Copy link
Collaborator

@codingdrone You need to assign yourself to the ticket and remove the label - else this ticket is open for others to work on. Let me know if you are facing issues with it

@codingdrone
Copy link

I couldn't assign as x.topcoder didn't work, please assign this issue.

@callmekatootie
Copy link
Collaborator

No worries - Have you worked with TCX before - just making sure that there is a mapping between your topcoder and github handles... ?

@codingdrone
Copy link

yes, worked with TCX on other projects.

@callmekatootie
Copy link
Collaborator

Cool. Added you - could you try assigning now

@codingdrone
Copy link

thanks

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 23, 2020

Contest https://www.topcoder.com/challenges/30133978 has been updated - it has been assigned to codingdrone.

This is an automated message for lazybaer via Topcoder X

@callmekatootie
Copy link
Collaborator

@codingdrone Could you kindly give a status check here - if you are not actively working on this, I would like to open this for pickup

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 24, 2020

Contest https://www.topcoder.com/challenges/30133978 has been updated - it has been assigned to rashmi73.

This is an automated message for lazybaer via Topcoder X

@rashmi73 rashmi73 removed their assignment Jul 25, 2020
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2020

Contest https://www.topcoder.com/challenges/30133978 has been updated - it has been assigned to genycopedison.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30133978

This is an automated message for lazybaer via Topcoder X

@callmekatootie
Copy link
Collaborator

@phongnt 2 issues with the changes made:

  • Search using the header input is no longer working
  • Sorting is no longer working

I think it is because of the changes made in this ticket - but please let me know if it is not

@callmekatootie
Copy link
Collaborator

@phongnt Can you please check this out on priority - a critical feature is no longer working

@phongnt
Copy link
Collaborator

phongnt commented Jul 26, 2020

@phongnt Can you please check this out on priority - a critical feature is no longer working

Let me check again

@phongnt
Copy link
Collaborator

phongnt commented Jul 26, 2020

@phongnt 2 issues with the changes made:

  • Search using the header input is no longer working
  • Sorting is no longer working

I think it is because of the changes made in this ticket - but please let me know if it is not

@callmekatootie Yes, you are correct. How to fix this side affect?

phongnt added a commit that referenced this issue Jul 26, 2020
phongnt added a commit that referenced this issue Jul 27, 2020
callmekatootie added a commit that referenced this issue Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working medium priority Not a roadblock to release but must be addressed at some point tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Development

No branches or pull requests

7 participants