Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$10] "X" button should be disabled if the field is empty #138

Closed
winterflame opened this issue Jul 12, 2020 · 3 comments
Closed

[$10] "X" button should be disabled if the field is empty #138

winterflame opened this issue Jul 12, 2020 · 3 comments
Labels
bug Something isn't working low priority To be fixed, but could be re-prioritized.
Milestone
v1.0 - Initial La...

Comments

@winterflame
Copy link

Reproduction Steps

  1. login to the app

  2. observe the "X" button on the top

Expected Result

"X" button should be disabled if the field is empty

Actual Result

See screenshot

Screenshot and/or screencast

close

Issue Information

Device/OS: Mac Book Pro, macOS Catalina Version 10.15.5

Browser Version: Firefox 78.0.2 (64-bit)
@callmekatootie
Copy link
Collaborator

valid bug

@callmekatootie callmekatootie added the bug Something isn't working label Jul 15, 2020
@wdprice wdprice added the low priority To be fixed, but could be re-prioritized. label Jul 20, 2020
@wdprice wdprice added this to the v1.0 - Initial Launch milestone Jul 20, 2020
@callmekatootie callmekatootie changed the title "X" button should be disabled if the field is empty [$10] "X" button should be disabled if the field is empty Jul 21, 2020
@callmekatootie
Copy link
Collaborator

Expected: In the header, if there is no search text, then do not show the "X" that clears the input

@callmekatootie callmekatootie mentioned this issue Jul 21, 2020
Closed
callmekatootie added a commit that referenced this issue Jul 22, 2020
@callmekatootie
#138 - Hide clear text button if there is no text to clear
8ee5c08
@callmekatootie
Copy link
Collaborator

Resolved

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working low priority To be fixed, but could be re-prioritized.
Projects
None yet
Milestone
v1.0 - Initial Launch
Development

No branches or pull requests
3 participants
@callmekatootie @winterflame @wdprice