Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Escape reserved regex characters when querying attribute value. Fixes… #20

Merged
merged 1 commit into from
Jul 28, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/common/es-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,16 @@ function getTotalCount (total) {
return typeof total === 'number' ? total : total.value
}

function escapeRegex(str) {
return str
.replace(/[\*\+\-=~><\"\?^\${}\(\)\:\!\/[\]\\\s]/g, '\\$&') // replace single character special characters
.replace(/\|\|/g, '\\||') // replace ||
.replace(/\&\&/g, '\\&&') // replace &&
.replace(/AND/g, '\\A\\N\\D') // replace AND
.replace(/OR/g, '\\O\\R') // replace OR
.replace(/NOT/g, '\\N\\O\\T'); // replace NOT
}

async function getOrganizationId (handle) {
const DBHelper = require('../models/index').DBHelper

Expand Down Expand Up @@ -573,6 +583,7 @@ function setUserAttributesFiltersToEsQuery (filterClause, attributes) {
attribute.value = [attribute.value]
}


filterClause.push({
nested: {
path: USER_ATTRIBUTE.esDocumentPath,
Expand All @@ -586,8 +597,8 @@ function setUserAttributesFiltersToEsQuery (filterClause, attributes) {
should: attribute.value.map(val => {
return {
query_string: {
default_field: `${[USER_ATTRIBUTE.esDocumentValueStringQuery]}`,
query: `*${val.replace(/ +/g, ' ').split(' ').join('* AND *')}*`
default_field: `${[USER_ATTRIBUTE.esDocumentValueQuery]}`,
query: `*${val.replace(/ +/g, ' ').split(' ').map(p => escapeRegex(p)).join('* AND *')}*`
}
}
}),
Expand Down Expand Up @@ -711,7 +722,7 @@ function buildEsQueryFromFilter (filter) {
* @param {*} char the char to check
*/
function isRegexReserved (char) {
const reserved = '[^$.|?*+(){}\\'
const reserved = '^$#@&<>~.?+*|{}[]()"\\'
return reserved.indexOf(char) !== -1
}

Expand Down