Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Copilot payments: Code quality #58

Closed
jmgasper opened this issue Aug 20, 2018 · 0 comments
Closed

Copilot payments: Code quality #58

jmgasper opened this issue Aug 20, 2018 · 0 comments

Comments

@jmgasper
Copy link
Collaborator

A few issues to clean up:

This flag should be a boolean:
closed: { type: String, required: true, default: "false" }

Should check here for invalid challenge ids:

async function getChallenges() {
... 

const challenges = _.get(response, 'data.result.content');
    logger.debug('Successfully retrieved challenges.');
    return challenges;
  } catch (err) {
 async function getChallengeById(id) {
...  const challenge = _.get(response, 'data.result.content');
    return challenge;
  } catch (er) {
    throw errors.convertTopcoderApiError(er, 'Failed to get challenge details by Id');
  }

Everywhere in file names, you use the term 'Payment' - This should be 'CopilotPayment' so it's fully clear that this is not referring to member payment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant