Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$75] Handling multiple repos of the same URL #279

Closed
jmgasper opened this issue Jan 8, 2020 · 5 comments
Closed

[$75] Handling multiple repos of the same URL #279

jmgasper opened this issue Jan 8, 2020 · 5 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Jan 8, 2020

https://github.com/topcoder-platform/topcoder-x-receiver/blob/be622f04597a76aeba11b7ffb58b645553265590/routes/middlewares/SecurityChecker.js#L20

For topcoder-platform/community-app, there were 3 entries in the TCX dynamo DB for the same git repo. The linked line above was pulling the first it found, checking the secret, and saying it's an invalid request.

  1. That line should pull all repos that match the URL and check the secret against each one
@jmgasper jmgasper changed the title Handling multiple repos of the same UI Handling multiple repos of the same URL Jan 8, 2020
@jmgasper jmgasper changed the title Handling multiple repos of the same URL [$75] Handling multiple repos of the same URL Mar 26, 2020
@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30120926 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30120926 has been updated - it has been assigned to afrisalyp.

This is an automated message for ghostar via Topcoder X

@afrisalyp
Copy link
Collaborator

@jmgasper

I think the Github webhook creation is broken. I'm not able to do "Add Webhook". I see that the March challenge commit has some changes on the code related to webhook creation, it might be related to it.

acd5be3#diff-fbd58dcb765282ff93e051fdc36265beL314

Do you confirm my findings?

@jmgasper
Copy link
Collaborator Author

#304

@jmgasper
Copy link
Collaborator Author

jmgasper commented Apr 7, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30120926

This is an automated message for ghostar via Topcoder X

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants