Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Receiver Repo Lookup doesn't handle multiple repos #15

Closed
rootelement opened this issue Jan 8, 2020 · 2 comments
Closed

Receiver Repo Lookup doesn't handle multiple repos #15

rootelement opened this issue Jan 8, 2020 · 2 comments
Assignees

Comments

@rootelement
Copy link
Contributor

https://github.com/topcoder-platform/topcoder-x-receiver/blob/be622f04597a76aeba11b7ffb58b645553265590/routes/middlewares/SecurityChecker.js#L20

For topcoder-platform/community-app, there were 3 entries in the TCX dynamo DB for the same git repo. The linked line above was pulling the first it found, checking the secret, and saying it's an invalid request.

Two things should happen:

  1. That line should pull all repos that match the URL and check the secret against each one
  2. We should consider not allowing multiple additions of the same repo? Maybe owner should be an array of people? Not sure what's best here.
@jmgasper
Copy link
Collaborator

jmgasper commented Jan 8, 2020

@rootelement - We can definitely add a check of all secrets. We can likely block additions of the same repo at the UI level.

@jmgasper
Copy link
Collaborator

jmgasper commented Jan 8, 2020

Moved to the UI issues, which is where I like to launch from: topcoder-archive/topcoder-platform-topcoder-x-ui#279

@jmgasper jmgasper closed this as completed Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants