Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

add tc api error fetch for create challenge #61

Merged
merged 1 commit into from
Nov 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions services/EventService.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ async function handleEventGracefully(event, data, err) {
// reschedule event
if (event.retryCount < config.RETRY_COUNT) {
logger.debug('Scheduling event for next retry');
const newEvent = {...event};
const newEvent = { ...event };
newEvent.retryCount += 1;
delete newEvent.copilot;
const timeoutKey = setTimeout(async () => {
Expand All @@ -77,13 +77,18 @@ async function handleEventGracefully(event, data, err) {
comment = `The challenge cancel failed: ${comment}`;
}
} else if (event.event === 'issue.created') {
// comment for challenge creation failed
comment = 'The challenge creation on the Topcoder platform failed. Please contact support to try again';
if (err.name === 'ProcessorError' && err.statusCode && err.message) {
// comment for challenge creation failed
comment = `[${err.statusCode}]: ${err.message}`
} else {
// comment for challenge creation failed
comment = 'The challenge creation on the Topcoder platform failed. Please contact support to try again';
}
} else if (event.event === 'copilotPayment.add') {
// comment for copilot payment challenge create failed
comment = 'The copilot payment challenge creation on the Topcoder platform failed. Please contact support to try again';
await dbHelper.remove(models.CopilotPayment, {
id: {eq: data.id}
id: { eq: data.id }
});
// we dont need to put comment for copilot payment
return;
Expand Down
10 changes: 5 additions & 5 deletions utils/errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,15 @@ errors.convertGitLabError = function convertGitLabError(err, message) {
*/
errors.convertTopcoderApiError = function convertTopcoderApiError(err, message) {
let resMsg = `${message}`;
const detail = _.get(err, 'response.body.result.content');
const detail = _.get(err, 'response.data.message');
if (detail) {
resMsg += ` Detail: ${detail}`;
}
const apiError = new ProcessorError(
err.status || _.get(err, 'response.body.result.status', constants.SERVICE_ERROR_STATUS),
resMsg,
'topcoder'
);
err.response.status || _.get(err, 'response.body.result.status', constants.SERVICE_ERROR_STATUS),
resMsg,
'topcoder'
);
return apiError;
};

Expand Down