Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

fixes for processing order for assignment #5

Merged
merged 1 commit into from
Jul 6, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions services/IssueService.js
Original file line number Diff line number Diff line change
@@ -78,7 +78,7 @@ async function handleEventGracefully(event, issue, err) {
if (event.event === 'issue.closed' && event.paymentSuccessful === false) {
comment = `Payment failed: ${comment}`;
}
if (event.retryCount <= 1) {
if (event.retryCount === config.RETRY_COUNT) {
// notify error in git host
if (event.provider === 'github') {
await gitHubService.createComment(event.copilot, event.data.repository.name, issue.number, comment);
@@ -506,13 +506,14 @@ async function handleIssueCreate(event, issue) {
} else {
await gitlabService.createComment(event.copilot, event.data.repository.id, issue.number, comment);
}

// if assignee is added during issue create then assign as well
if (event.data.issue.assignees && event.data.issue.assignees.length > 0 && event.data.issue.assignees[0].id) {
event.data.assignee = {
id: event.data.issue.assignees[0].id
};
await handleIssueAssignment(event, issue);
if (event.provider === 'gitlab') {
// if assignee is added during issue create then assign as well
if (event.data.issue.assignees && event.data.issue.assignees.length > 0 && event.data.issue.assignees[0].id) {
event.data.assignee = {
id: event.data.issue.assignees[0].id
};
await handleIssueAssignment(event, issue);
}
}

logger.debug(`new challenge created with id ${issue.challengeId} for issue ${issue.number}`);