Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Conversation

PrakashDurlabhji
Copy link
Contributor

No description provided.

@sushilshinde
Copy link
Contributor

@PrakashDurlabhji please PR to qa-accessibility branch

@veshu
Copy link
Contributor

veshu commented Jul 25, 2019

@PrakashDurlabhji Please change the target branch.

Also, please double check that you are not altering the theme of the tags. please check here https://marvelapp.com/c7h2a6h/screen/59648056/handoff for color palette.

@PrakashDurlabhji PrakashDurlabhji changed the base branch from develop to qa-accessibility July 25, 2019 16:27
@PrakashDurlabhji
Copy link
Contributor Author

@veshu yes i am not updating the theme color at all. it is same from color pallete.
branch changed

@veshu
Copy link
Contributor

veshu commented Jul 25, 2019

You are totally breaking the theme here, you have changed the green button to blue button. white text to gray text. I am rejecting this PR which is not acceptable.

Also please ask if you need color help, don't make review slower by wrong fixes.

@veshu veshu assigned codeMinter and unassigned codeMinter Jul 25, 2019
@PrakashDurlabhji
Copy link
Contributor Author

@veshu sorry for that if wrong, but it will just change it when hovered. because that needs to be matched correct? similar to others?

@veshu
Copy link
Contributor

veshu commented Jul 29, 2019

@PrakashDurlabhji The development tags code, first2Finish are green , design and design f2f are blue, and marathon have orange color, they should be same even for highlight

Check my temp fixes https://monosnap.com/file/GvuXzytRFfu1CL8JyCD4z2aTtp5DNZ ,

When button or tag background color is .button {
background-color: $tc-light-blue; then when hover /active make the background-color to $tc-light-blue-110

similar for green the normal background color will be $tc-green now you need to change $tc-green-110 for hover/active case.

make sure to do on all three files https://github.com/topcoder-platform/topcoder-react-ui-kit/tree/qa-accessibility/src/shared/components/tags

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants