Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

MSFT-22 #18

Closed
wants to merge 1 commit into from
Closed

MSFT-22 #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/styles/_mixins/variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@ $tc-dark-blue-30: #cee6ff;
$tc-dark-blue-10: #f4f9ff;

/* Light Blue - design color code. */
$tc-light-blue-110: #169ed9;
$tc-light-blue-110: #0076a5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r0hit-gupta I can't find this color on palette

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This color should be used 0B71E6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veshu color #0B71E6 is not on the palette either.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r0hit-gupta I think we can close this PR, please use variable $tc-light-blue-110 color in the app. We shouldn't be needing this PR, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veshu I am already using the variable $tc-light-blue-110 in the app. This PR won't be needed anymore after #19 is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I am closing this PR, please make sure your issue reference this PR, so reviewer would accept the issue. Thanks

$tc-light-blue-100: #26ade9;
$tc-light-blue-70: #67c5ef;
$tc-light-blue-30: #bde6f8;
$tc-light-blue-10: #e9f6fc;

/* Warm Orange - data science color code. */
$tc-orange-110: #f26500;
$tc-orange-110: #ba4c00;
$tc-orange-100: #fb7d22;
$tc-orange-70: #fda464;
$tc-orange-30: #fee3d0;
Expand All @@ -74,7 +74,7 @@ $tc-yellow-10: #fffde5;

/* Greens - development color code. */
$tc-green-120: #328732;
$tc-green-110: #55b000;
$tc-green-110: #258025;
$tc-green-100: #60c700;
$tc-green-70: #96d957;
$tc-green-30: #cfefb2;
Expand Down