Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Copy the latest colors from the old UI Kit #1

Closed
vic-tian opened this issue Jan 30, 2018 · 2 comments
Closed

Copy the latest colors from the old UI Kit #1

vic-tian opened this issue Jan 30, 2018 · 2 comments

Comments

@vic-tian
Copy link

@birdofpreyru - I've fixed the wrong colors in our _variables.scss https://github.com/appirio-tech/tc-ui/blob/feature/connectv2/src/styles/_variables.scss

These are the correct colors and semantically separating color names from variable names. They work as a drop-in replacement without any need to refactor the code right away. I saw we missed the yellow gamma entirely, while there was a gold one that I didn't define.

Please make sure we're using the correct colors from the file I shared.

birdofpreyru added a commit that referenced this issue Jan 31, 2018
@birdofpreyru
Copy link
Collaborator

Ok, done, the demo page is temporarily here: https://community-app.topcoder-dev.com/examples/color-mixins

@vic-tian
Copy link
Author

vic-tian commented Feb 1, 2018

Looks great! I'll include this with all design specs from now on! 👍

sushilshinde pushed a commit that referenced this issue Jul 31, 2019
sushilshinde pushed a commit that referenced this issue Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants