Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Add robust unit tests #25

Merged
merged 5 commits into from
Dec 16, 2019

Conversation

imcaizheng
Copy link
Contributor

True unit tests. No real download or upload or zipping.

Copy link
Collaborator

@sharathkumaranbu sharathkumaranbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still two tests fail in my system and I am in the right branch and repo.

image

I am using Ubuntu 18.04. Also, please note that the folders are still being created inside the repo. It shouldn't happen as well.

image

The code repo should remain as is. No additional folders or files should be created.

@imcaizheng
Copy link
Contributor Author

imcaizheng commented Dec 15, 2019

I can reproduce the errors only by setting WAIT_TIME to below ~200ms before running the tests.
I think the default WAIT_TIME should be sufficient for running the tests though I still don't know why it doesn't work for you. I reduce the total number of artifacts in test/common/testData.js so that the fetch-artifacts command could exit more quickly. Let me know if the new changes could help you run the tests without errors.

@sharathkumaranbu
Copy link
Collaborator

sharathkumaranbu commented Dec 16, 2019

If I increase the timeout in my system, it works fine. We will try in the CI / CD pipeline.

Copy link
Collaborator

@sharathkumaranbu sharathkumaranbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now.

@sharathkumaranbu sharathkumaranbu merged commit d524a84 into topcoder-archive:develop Dec 16, 2019
@imcaizheng imcaizheng deleted the final-fix branch December 16, 2019 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants