Jobs and Resource Bookings Management #76
Conversation
Jobs and Booking Resource Management Submission.
| }; | ||
|
|
||
| FormField.prototype = { | ||
| fields: PT.arrayOf( |
There was a problem hiding this comment.
FormField doesn't accept fields it accept field - one value.
| ); | ||
| }; | ||
|
|
||
| FormField.prototype = { |
There was a problem hiding this comment.
It should be propTypes not prototype.
| readonly: PT.string, | ||
| }) | ||
| ).isRequired, | ||
| isGroupField: PT.bool, |
There was a problem hiding this comment.
Let's remove this prop isGroupField together with class "field-group-field". Instead of this parent component should put this field into a group.
| input:not([type="checkbox"]), | ||
| textarea { | ||
| margin-bottom: 0px; | ||
| } | ||
|
|
||
| input:read-only { | ||
| margin-top: 24px; | ||
| } |
There was a problem hiding this comment.
Can we put these styles into respective components TextInput, TextArea and so one where we need them. This common component should not add styles for particular field types.
Also, we should not use global selectors like input and textarea. We should use classes instead. Or at least.someClass input.
| return ( | ||
| <textarea | ||
| auto | ||
| className={`TextArea ${props.className} ${props.value ? "" : "empty"}`} |
There was a problem hiding this comment.
Can we use styleName instead of className?
| textarea { | ||
| resize: none; | ||
| background-color: #ffffff; | ||
| border: 1px solid #aaaaaa; | ||
| border-radius: 6px; | ||
| height: 320px; | ||
| } |
There was a problem hiding this comment.
Let's not define global styles, and use some class name instead.
| button { | ||
| height: 40px; | ||
| border-radius: 20px; | ||
| min-width: 78px; | ||
| } |
There was a problem hiding this comment.
We already have styles inside Button component. Do we really need this? we can define <Button size={BUTTON_SIZE.MEDIUM} />
fixed styles for job-rb
- also, fix User profile link and refactor
No description provided.