-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoution works great, just one code improvement below:
@yoution one more thing. We use pagination not only on the teams list, but also on other pages. After this fix, the vertical alignment is broken on other pages (there is extra space under the page number now): |
c216704
to
cf7ef0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoution there are still 2 things:
- comment below and
fix: issue#54 #59 (comment)(update: this is fixed)
@@ -15,6 +17,9 @@ | |||
border-color: #2A2A2A; | |||
} | |||
|
|||
> button[class] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoution this technically works, but if someone new look at this it's not clear what does it mean and why we did so. Could we replace it with some more clear way, for example,.page, .next, .prev { margin-bottom: 10px; }
, it's more wordy, but it's more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoution this #59 (comment) already works, thanks!
Sorry @yoution this is fixed #59 (comment) So only this one is left #59 (comment) |
cf7ef0f
to
1bdf6cd
Compare
Example link to comment #59 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoution after the last fix when I run npm run dev
I get error:
1bdf6cd
to
a03b496
Compare
@maxceem sorry, push again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the small fixes @yoution. Works perfect now.
No description provided.