Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

fix: issue #562 #578

Merged
merged 3 commits into from
Nov 26, 2021
Merged

fix: issue #562 #578

merged 3 commits into from
Nov 26, 2021

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Nov 25, 2021

@maxceem please review

maxceem
maxceem suggested changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution works good, but the font is different, could we fix the font?

image

@yoution
Copy link
Contributor Author

yoution commented Nov 25, 2021 •
edited
Loading

which browser do you use?
which font do we need?

@maxceem
Copy link
Contributor

maxceem commented Nov 25, 2021

I use Google Chrome on macOS.

We need the same font Nylas us in their page I guess this one https://monosnap.com/file/GA18Q8gndb1qnyLAmKzWz9PN9KvH8k

@yoution yoution requested a review from maxceem November 25, 2021 09:24
maxceem
maxceem suggested changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution it still looks different from the real page.

Please, see the video https://monosnap.com/file/ZIGfEfLkmj3CIYPSYRXaVX25nKi3bF

Can we make the styles the same? So when this page is shown it looks like a real page?

To get styles from the real page, you may select a time on this page https://schedule.nylas.com/tc-taas-interview-70e34e1e-cff6-4483-93dc-2e3923658578 and you would see the real page. So you could copy the exact styles.

Also, could we please show the Checkmark to make it the same https://monosnap.com/file/hLAoDw8sJBVTwdQEqhcXmGx3nqIX1S

@yoution yoution requested a review from maxceem November 26, 2021 11:30
maxceem
maxceem approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution looks good. Merging for QA.

@maxceem maxceem merged commit d0a35d6 into topcoder-archive:dev Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxceem maxceem maxceem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoution @maxceem