This repository was archived by the owner on Mar 13, 2025. It is now read-only.
fix: error message for #44 #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
suggested changes
Jan 9, 2021
There was a problem hiding this comment.
There is one missing requirement and a couple of small improvements for the code.
-
If the promise is rejected, then some error happens during Authentication. So instead of the page, we have to show an error message.
Imagine if some error happens during authentication. To simulate it we can add
throw new Error("Auth error");insidegetAuthUserTokensmethod:
As a result error would happen during loading. This error should be shown, but the moment empty page is show:
|
@maxceem please review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maxceem please review for #44