This repository was archived by the owner on Mar 13, 2025. It is now read-only.
fix(create-new-team): design issues #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the `src/routes/CreateNewTeam/components/progress`, which is the same with `src/routes/CreateNewTeam/components/Progress` (capital P) * The actual component being used in the app. is `Progress`. `progress` has no use. * Having two folders (`progress` and `Progress`) causing troubles on case-insensitive OSs.
* Enhances the design of `Progress` and `ProgressBar` components, as per the https://marvelapp.com/prototype/89c7i66/screen/81081387. Addresses topcoder-archive#406
* Center the image. * Decrease margins and paddings not to trigger scrollbar unnecessarily. Addresses topcoder-archive#402 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progressfoldersrc/routes/CreateNewTeam/components/progress,which is the same with
src/routes/CreateNewTeam/components/Progress(capital P)Progress.progresshas no use.progressandProgress) causing troubles on case-insensitive OSs.Enhances the design of
ProgressandProgressBarcomponents,as per the https://marvelapp.com/prototype/89c7i66/screen/81081387.
Addresses Update Progress Tracker #406
Center the image.
Decrease margins and paddings not to trigger scrollbar unnecessarily.
Addresses Update Customer Scroll to be static #402 (comment)