This repository was archived by the owner on Mar 13, 2025. It is now read-only.
fix: issue #16 #39
Closed
fix: issue #16 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
suggested changes
Dec 31, 2020
| @@ -0,0 +1,43 @@ | |||
| import axios from "axios"; | |||
| import store from "../store"; | |||
| import { getFreshToken, isTokenExpired } from "@topcoder-platform/tc-auth-lib"; | |||
There was a problem hiding this comment.
@yoution we should not use @topcoder-platform/tc-auth-lib directly. We should always getAuthUserTokens from @topcoder/micro-frontends-navbar-app
|
|
||
| // request interceptor to pass auth token | ||
| axiosInstance.interceptors.request.use((config) => { | ||
| return getToken() |
There was a problem hiding this comment.
@yoution just replace this line with getAuthUserTokens and then(({ tokenV3: token }) => { - something like this. We don't need refresh token logic, method getAuthUserTokens should do this for us.
yoution
added a commit
to yoution/taas-app
that referenced
this pull request
Jan 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maxceem please review, Automatically get token during API requests using Axios