Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

fix: issue #135 #136

Merged
merged 2 commits into from
Mar 3, 2021
Merged

fix: issue #135 #136

merged 2 commits into from
Mar 3, 2021

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Mar 3, 2021

@maxceem please review

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution the fix is really great! Thanks for refactoring and reusing the existent component. I've raised the payment for this tasks to $30 for such a solution.

There is only one small thing I'd like to improve. We are showing user handle as a blue link everywhere, for example for candidates https://platform.topcoder-dev.com/taas/myteams/16873/positions/eaa70908-20dc-488b-a9fb-e96dca98ec33/candidates

image

Why here is showing handles using big black text? Can we show it use smaller blue color?

image

Please, note, I'd like to reuse the functionality of existent component for this, without some hacky fixes. I'm not sure why it's not blue here like on other pages where we use the same component?

@yoution
Copy link
Contributor Author

yoution commented Mar 3, 2021

@maxceem why does it show black handle
in my computer, it bold blue style
image

@yoution yoution requested a review from maxceem March 3, 2021 13:00
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, now works good @yoution. Thank you.

@maxceem maxceem merged commit eaf780b into topcoder-archive:dev Mar 3, 2021
@yoution yoution deleted the issue-135 branch June 22, 2021 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants